Event key photo can be blurry
Submitted by Jim Nelson
Link to original bug (#715802)
Description
---- Reported by jim@yorba.org 2009-12-18 16:15:00 -0800 ----
Original Redmine bug id: 1202
Original URL: http://redmine.yorba.org/issues/1202
Searchable id: yorba-bug-1202
Original author: Jim Nelson
Original description:
If the thumbnail of an event's key photo is small (due to the size or dimensions of the original or cropped photo), the key photo can be blurry. Even if the original is large but oddly dimensioned (such as the attached photo), the key photo will be blurry.
This is due to using the thumbnail, and not the original, and blowing it up to make all events square and the same size.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:41:00 -0700 ----
History
Comment 1
Updated by Eric Gregory almost 3 years ago
Note: possibly the same issue as ticket #2613 (closed)
Comment 2
Updated by Lucas Beeler over 2 years ago
- Description updated (diff)
Ticketed downstream here: https://bugs.launchpad.net/shotwell/+bug/815414
Comment 3
Updated by Joe Bylund 8 months ago
- File issue_1202.patch added
- Description updated (diff)
- Target version set to 0.15.0
- % Done changed from 0 to 10
I'm slightly confused on this because I put in a panorama, and the thumbnail dimensions were
thumbnail dimensions = 1084 x 244
paul lynde dimensions = 244 x 244
so I wouldn't have thought it would be blurry, but it was. Maybe that should be a different bug?
But in any case, I tried to use the full image if either thumbnail dimension is too large (since the smaller dimension is always 244). We might want to use slightly different logic in the if statement.
Comment 4
Updated by Jim Nelson 8 months ago
- Category set to events
- Status changed from Open to Review
Comment 5
Updated by Anonymous 7 months ago
- Status changed from Review to 5
Applied in changeset 129c710a.
Comment 6
Updated by Lucas Beeler 7 months ago
- Resolution set to fixed
Comment 7
Updated by Lucas Beeler 7 months ago
@Joe: I committed your patch because the code was solid and it fixed the problem over several test cases. That said, I'm curious about what you meant when you said this:
I'm slightly confused on this because I
put in a panorama, and the thumbnail
dimensions were
thumbnail dimensions = 1084 x 244
paul lynde dimensions = 244 x 244
so I wouldn't have thought it would be
blurry, but it was. Maybe that should be
a different bug?
So, are you saying that even before you applied your patch, the minor axis on the thumbnail dimensions was 244 (i.e., large enough to satisfy the paul_lynde dimensions without scaling?)
Comment 8
Updated by Joe Bylund 7 months ago
So, are you saying that even before you applied your patch, the minor axis on the thumbnail dimensions was 244 (i.e., large enough to satisfy the paul_lynde dimensions without scaling?)
Exactly, which is why I was surprised that the key photo was blurry, since you should be able to make a 244x244 thumbnail from a 1084x244 image without any issues. And I'm wondering if the same code path isn't hit from multiple other places.
That said, at the moment there are more important things since it doesn't seem to be causing any issues now, and at worst it's probably a very slight performance hit from pulling a bigger thumbnail & event thumbnail generation isn't a frequent event.
Comment 9
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:42 UTC ---
This bug was previously known as bug 1202 at http://redmine.yorba.org/show_bug.cgi?id=1202 Imported an attachment (id=261552) Imported an attachment (id=261553)
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. The original submitter of attachment 261553 was joseph.bylund+shotwell@gmail.com, but he doesn't have an account here. Reassigning to the person who moved it here: chaz@yorba.org.
Version: 0.15.0
Resolution: RESOLVED FIXED