investigate valgrind warnings
Submitted by Adam Dingle
Link to original bug (#715750)
Description
---- Reported by adam@yorba.org 2010-01-22 09:28:00 -0800 ----
Original Redmine bug id: 1308
Original URL: http://redmine.yorba.org/issues/1308
Searchable id: yorba-bug-1308
Original author: Adam Dingle
Original description:
If I run Shotwell under valgrind and import a photo, valgrind reports a write with uninitialized memory:
30497 Syscall param write(buf) points to uninitialised byte(s)
30497 at 0×58A803B: ? (in /lib/tls/i686/cmov/libc-2.10.1.so)
30497 by 0×40872AC: ? (in /usr/lib/libsqlite3.so.0.8.6)
30497 by 0×40AD506: ? (in /usr/lib/libsqlite3.so.0.8.6)
30497 by 0×40AD5D9: ? (in /usr/lib/libsqlite3.so.0.8.6)
30497 by 0×40B0E2C: ? (in /usr/lib/libsqlite3.so.0.8.6)
30497 by 0×40E9490: ? (in /usr/lib/libsqlite3.so.0.8.6)
30497 by 0×40D7C32: sqlite3_step (in /usr/lib/libsqlite3.so.0.8.6)
30497 by 0×8069623: photo_table_add (!DatabaseTables.vala:504)
…
It would be nice to investigate this. Even if the error is benign, it might be better to modify our code so that the error doesn't occur, just so that we can more easily spot true problems using valgrind in the future.
---- Additional Comments From shotwell-maint@gnome.bugs 2011-03-29 08:48:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 2
Updated by Adam Dingle over 3 years ago
- Priority set to Low
Comment 3
Updated by Adam Dingle over 2 years ago
- Priority changed from Low to High
- Subject changed from valgrind reports uninitialized write to investigate valgrind warnings
As of 0.9, if I run Shotwell under valgrind in Natty I see various warnings. Some of these may be bugs in other libraries. In any case it would be nice to track down and eliminate these, filing bugs in other projects as appropriate.
Conditional jump or move depends on uninitialised value(s)
==30510== at 0xCC74510: inflateReset2 (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
==30510== by 0xCC74605: inflateInit2_ (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
==30510== by 0x103201B0: png_create_read_struct_2 (in /lib/x86_64-linux-gnu/libpng12.so.0.44.0)
==30510== by 0x18087215: ??? (in /usr/lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so)
==30510== by 0xA01771D: ??? (in /usr/lib/libgdk_pixbuf-2.0.so.0.2300.1)
==30510== by 0xA017A0B: gdk_pixbuf_new_from_file (in /usr/lib/libgdk_pixbuf-2.0.so.0.2300.1)
==30510== by 0x590A0D: resources_add_stock_icon (in /usr/bin/shotwell)
==30510== by 0x590E11: resources_init (in /usr/bin/shotwell)
==30510== by 0x4FB081: _vala_main (in /usr/bin/shotwell)
==30510== by 0x4FB178: main (in /usr/bin/shotwell)
==30510==
==30510== Invalid read of size 8
==30510== at 0xC94D3BF: __GI___strncasecmp_l (strcmp.S:213)
==30510== by 0xC903FAE: ____strtod_l_internal (strtod_l.c:577)
==30510== by 0xBABB4D0: g_ascii_strtod (gstrfuncs.c:566)
==30510== by 0x17C1DD66: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C35483: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C36BD1: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C379B4: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3AC3E: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3B5EA: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x6DB3778: xmlParseStartTag (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBBF5E: ??? (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBCD2F: xmlParseChunk (in /usr/lib/libxml2.so.2.7.8)
==30510== Address 0x185724a0 is 0 bytes inside a block of size 7 alloc'd
==30510== at 0x4C28FAC: malloc (vg_replace_malloc.c:236)
==30510== by 0xBAA2A62: g_malloc (gmem.c:164)
==30510== by 0xBABB06D: g_strdup (gstrfuncs.c:102)
==30510== by 0x17C36B9E: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C379B4: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3AC3E: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3B5EA: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x6DB3778: xmlParseStartTag (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBBF5E: ??? (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBCD2F: xmlParseChunk (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x17C3C78E: rsvg_handle_write (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17A12C10: ??? (in /usr/lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-svg.so)
==30510==
==30510== Invalid read of size 8
==30510== at 0xC94D3C7: __GI___strncasecmp_l (strcmp.S:215)
==30510== by 0xC903FAE: ____strtod_l_internal (strtod_l.c:577)
==30510== by 0xBABB4D0: g_ascii_strtod (gstrfuncs.c:566)
==30510== by 0x17C1DD66: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C35483: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C36BD1: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C379B4: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3AC3E: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3B5EA: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x6DB3778: xmlParseStartTag (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBBF5E: ??? (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBCD2F: xmlParseChunk (in /usr/lib/libxml2.so.2.7.8)
==30510== Address 0x185724a8 is 1 bytes after a block of size 7 alloc'd
==30510== at 0x4C28FAC: malloc (vg_replace_malloc.c:236)
==30510== by 0xBAA2A62: g_malloc (gmem.c:164)
==30510== by 0xBABB06D: g_strdup (gstrfuncs.c:102)
==30510== by 0x17C36B9E: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C379B4: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3AC3E: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17C3B5EA: ??? (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x6DB3778: xmlParseStartTag (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBBF5E: ??? (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x6DBCD2F: xmlParseChunk (in /usr/lib/libxml2.so.2.7.8)
==30510== by 0x17C3C78E: rsvg_handle_write (in /usr/lib/librsvg-2.so.2.32.1)
==30510== by 0x17A12C10: ??? (in /usr/lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-svg.so)
==30510==
==30510== Conditional jump or move depends on uninitialised value(s)
==30510== at 0xCC74510: inflateReset2 (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
==30510== by 0xCC74605: inflateInit2_ (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
==30510== by 0x103201B0: png_create_read_struct_2 (in /lib/x86_64-linux-gnu/libpng12.so.0.44.0)
==30510== by 0x18086979: ??? (in /usr/lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so)
==30510== by 0xA019771: ??? (in /usr/lib/libgdk_pixbuf-2.0.so.0.2300.1)
==30510== by 0xA01A2B7: gdk_pixbuf_loader_close (in /usr/lib/libgdk_pixbuf-2.0.so.0.2300.1)
==30510== by 0xA017078: ??? (in /usr/lib/libgdk_pixbuf-2.0.so.0.2300.1)
==30510== by 0xA017F79: gdk_pixbuf_new_from_stream (in /usr/lib/libgdk_pixbuf-2.0.so.0.2300.1)
==30510== by 0x8F6317F: icon_info_ensure_scale_and_pixbuf (gtkicontheme.c:2993)
==30510== by 0x8F66911: gtk_icon_info_load_icon (gtkicontheme.c:3076)
==30510== by 0x590C0C: resources_add_stock_icon_from_themed_icon (in /usr/bin/shotwell)
==30510== by 0x590FE0: resources_init (in /usr/bin/shotwell)
==30510==
--- Bug imported by chaz@yorba.org 2013-11-25 21:42 UTC ---
This bug was previously known as bug 1308 at http://redmine.yorba.org/show_bug.cgi?id=1308
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Resolution: RESOLVED OBSOLETE