show actual camera name
Submitted by Adam Dingle
Assigned to Eric Gregory
Link to original bug (#715684)
Description
---- Reported by adam@yorba.org 2009-10-06 14:50:00 -0700 ----
Original Redmine bug id: 854
Original URL: http://redmine.yorba.org/issues/854
Searchable id: yorba-bug-854
Original author: Adam Dingle
Original description:
Shotwell displays my camera as “%(=caps)USB% PTP Class Cameraâ€, but iPhoto displays the same camera as “Canon Powershot SD1200 ISâ€. Shotwell should display the actual camera name.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:41:00 -0700 ----
History
Comment 1
Updated by Adam Dingle about 4 years ago
- Priority set to High
Comment 2
Updated by Adam Dingle about 4 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 3
Updated by Adam Dingle over 3 years ago
-
Target version deleted (
<strike>
__</strike>
) - Priority set to High
Comment 4
Updated by Adam Dingle over 3 years ago
- Tracker changed from Bug to Feature
Comment 5
Updated by Adam Dingle over 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 6
Updated by Jan-Christoph Borchardt over 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Jan-Christoph Borchardt
Comment 7
Updated by Jan-Christoph Borchardt over 3 years ago
Ah! The radio button got me again and I cant change it back
Comment 8
Updated by Jim Nelson over 3 years ago
- Assignee changed from Jan-Christoph Borchardt to Anonymous
Comment 9
Updated by Adam Dingle about 3 years ago
- Priority set to High
The Ubuntu Places menu shows my camera as “Canon Digital Cameraâ€, so I'd like to think that Shotwell could also display a nicer name like this. I think we should at least investigate how hard this would be; upping to high.
Comment 10
Updated by Adam Dingle about 3 years ago
I investigated. The GVFS gphoto2 backend gets the nice camera name by making a couple of udev calls: in compute_display_name() in daemon/gvfsbackendgphoto2.c in the GVFS source distribution:
s = g_udev_device_get_sysfs_attr (gphoto2_backend->udev_device, "product");
if (s == NULL)
s = g_udev_device_get_property (gphoto2_backend->udev_device, "ID_MODEL");
If we have easy access to the udev device for each camera, it might be nice for us to do the same. If that wouldn't be easy, then we'll get nicer names automatically if and when we start using GVFS rather than gphoto2 (#2498 (closed)).
Comment 11
Updated by Jim Nelson about 3 years ago
It should be fairly easy for us to get the udev device and make these calls.
Comment 12
Updated by Adam Dingle about 3 years ago
That's good news!
Comment 13
Updated by Adam Dingle almost 3 years ago
- Assignee changed from Anonymous to Eric Gregory
Comment 14
Updated by Adam Dingle almost 3 years ago
Also worth looking at: set_volume_name() in gvfs-1.6.6/monitor/gphoto2/ggphoto2volume.c .
Comment 15
Updated by Eric Gregory almost 3 years ago
It looks like GVFS is using libimobiledevice to get the iPhone name.
This seems to be the culprit. It's monitor/afc/afcvolume.c
if (lockdownd_get_device_name (lockdown_cli, &display_name) == LOCKDOWN_E_SUCCESS)
{
g_free (self->name);
self->name = display_name;
}
But Jim points out we can get this from GVFS directly. I found that if you run
gvfs-mount -l
it displays the name of the phone. So that seems like a viable option.
Comment 16
Updated by Eric Gregory almost 3 years ago
Name of the camera/phone is now show in Shotwell.
Fixed in r2398
Comment 17
Updated by Eric Gregory almost 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Comment 18
Updated by Eric Gregory almost 3 years ago
- Status changed from 5 to 4
-
Resolution deleted (
<strike>
_fixed_</strike>
) - % Done changed from 100 to 0
Still not quite right -- there's a bug in this that can cause the following error to appear in GDB:
- CRITICAL **: camera_table_get_name_for_uuid: assertion `uuid != NULL' failed
aborting…
Comment 19
Updated by Eric Gregory almost 3 years ago
- Status changed from 4 to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Issue in comment:19 fixed in r2411
Comment 20
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:42 UTC ---
This bug was previously known as bug 854 at http://redmine.yorba.org/show_bug.cgi?id=854
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED