about box links don't work
Submitted by an unknown user
Assigned to Adam Dingle
Link to original bug (#715524)
Description
---- Reported by shotwell-maint@gnome.bugs 2009-12-03 15:37:00 -0800 ----
Original Redmine bug id: 1074
Original URL: http://redmine.yorba.org/issues/1074
Searchable id: yorba-bug-1074
Original author: Yanko Kaneti
Original description:
As part of fixing 1033 some code was commited (r889) affecting the about box link handling. As a result on recent linux boxes clicking on the about box links produces nothing. It seems to me the logic there is inverted. On a linux box with a recent gtk there is no need to set a url hook, gtk itself will use gtk_show_url to handle it. Perhaps the intent was to set the hooks only on windows where gtk_show_url reportedly has some issues and doesn't work.
src/AppWindow.vala:339
-#if !WINDOWS
+#if WINDOWS
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:41:00 -0700 ----
History
Comment 1
Updated by Robert Powell almost 4 years ago
- Category changed from fillmore to 4
Comment 2
Updated by Adam Dingle almost 4 years ago
- Target version set to 0.4
- Priority set to High
Comment 3
Updated by Adam Dingle almost 4 years ago
- Status changed from Open to 5
- Resolution set to fixed
- % Done set to 100
Fixed. I simply removed the set_url_hook and set_email_hook calls. Now the links work fine with GTK 2.18. On GTK 2.16, the links are now displayed as plain text, not as links, but we can call that a GTK bug.
Comment 4
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:42 UTC ---
This bug was previously known as bug 1074 at http://redmine.yorba.org/show_bug.cgi?id=1074
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.4
Resolution: RESOLVED FIXED