icons in sidebar
Submitted by Adam Dingle
Link to original bug (#715485)
Description
---- Reported by adam@yorba.org 2009-05-22 09:01:00 -0700 ----
Original Redmine bug id: 295
Original URL: http://redmine.yorba.org/issues/295
Searchable id: yorba-bug-295
Original author: Adam Dingle
Original description:
It would be nice to have an icon beside each sidebar category (Photos, Events, Cameras).
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:42:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 4 years ago
- Priority set to High
Comment 2
Updated by Adam Dingle about 4 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 3
Updated by Adam Dingle over 3 years ago
-
Target version deleted (
<strike>
__</strike>
)
Comment 4
Updated by Adam Dingle over 3 years ago
- Priority set to High
Perhaps worth considering for 0.7.
Comment 5
Updated by Philip Beam over 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Philip Beam
Comment 6
Updated by Adam Dingle over 3 years ago
Philip,
thanks for your recent patches, and I'm glad you're interested in working on this enhancement as well. I hope you've gotten a chance to read the recent mailing list discussion about icons in the sidebar: see this message and the ones which preceded it:
http://lists.yorba.org/pipermail/shotwell/2010-July/000606.html
The conclusion was that we'd like the sidebar icons to look like this:
http://dl.dropbox.com/u/8668185/shotwell.png
In that picture, however, the black icon to the left of Photos isn't too inspiring. Instead, let's try using the main Shotwell icon there – I think it will look great. Thanks again for your help!
Comment 7
Updated by Philip Beam over 3 years ago
No problem, I'm glad to help. I have read the discussion, and agree that the icon is very plain, but I'm using the standard theme icons so it won't always look like that. The GNOME icon looks like this:
http://git.gnome.org/browse/gnome-icon- theme/plain/gnome/16×16/mimetypes/image-x-generic.png
There is also this one (Ubuntu theme is two black photos):
http://git.gnome.org/browse/gnome-icon-theme/plain/gnome/16×16/emblems /emblem-photos.png
If #1578 (closed) moves the Shotwell icon to the standard location it will be very easy to use it as the Photos icon. There is no standard “Tags†icon so a custom one may be needed.
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
Comment 8
Updated by Adam Dingle over 3 years ago
Aha – the emblem-photos icon actually looks pretty good and is theme- specific. We could display either that icon or the Shotwell icon to the left of Photos – either would be fine with me.
Can you design a custom Tags icon or find one online somewhere? If not, perhaps we can get some artist lurking on the Shotwell mailing list to make one for us.
Comment 9
Updated by Philip Beam over 3 years ago
I used the folder icon for Tags until a custom icon is available.
Comment 10
Updated by Adam Dingle over 3 years ago
Philip,
I just tried out your patch. I'll let Jim review the code, but the functionality looks great! This will be a really nice visual enhancement to Shotwell.
I do think that the default Ubuntu photos icon (the two black photos) looks too somber. We could either try to get Ubuntu to change it, or simply use the Shotwell icon instead. I might be inclined to use the Shotwell icon – that's the easier route, and I actually think it would look pretty good.
Comment 11
Updated by Philip Beam over 3 years ago
I didn't realize this at the time, but changing emblem-photos to shotwell works. It looks like the icon was installed into /usr/local/share/icons instead of /usr/share/icons. GTK finds it but it's the only icon there.
Comment 12
Updated by Philip Beam over 3 years ago
OK disregard that last message, installing through the package manager puts it in /usr/share/icons. I updated the patch to use the Shotwell icon for Photos.
Comment 13
Updated by Adam Dingle over 3 years ago
Philip,
I've tried your latest patch. A few comments:
- If a parent node has an icon (e.g. “Camerasâ€, “Tagsâ€) but its child nodes do not, then the child node text is not indented at all with respect to the parent node text. I think this looks a bit confusing: it's not immediately apparent that the child nodes are children of the parent. So I think we need to indent the children a bit and/or give them their own icons.
- WIth your patch, Shotwell displays the icon for the Photos item only when it is installed, not when I run it from the build directory. It's very important to us that Shotwell have full functionality when run from the build directory. I will say, though, that I'm still not completely sure that we want to use the Shotwell icon next to the Photos item rather than the emblem-photos icon. I'll discuss that today with others at Yorba and we'll make a decision about this.
Comment 14
Updated by Jim Nelson over 3 years ago
Philip,
I agree with Adam about his two points. Otherwise, the code looks good -- you're putting the icon resource names right where they should be, with the Pages.
Comment 15
Updated by Philip Beam over 3 years ago
This updated patch loads icons from the Shotwell icons directory if not found in the theme. I could only get indenting to work on the right side of the expanders, which didn't look very good, so I made them all have icons. Let me know what you think and if you have any ideas for icon choices.
Comment 16
Updated by Adam Dingle over 3 years ago
Philip,
thanks for your continued work on this feature. Making all the items have icons might work, though I'd have to see this in action to know what I think, really. I applied your patch, built and ran and saw this:
- ERROR **: Sidebar.vala:203: Error opening file: No such file or directory
aborting...
Could you advise as to what's wrong and/or send an updated patch? Thanks!
Comment 17
Updated by Philip Beam over 3 years ago
This might fix it. If not I added some debug info, and I also made it not show the icon instead of aborting.
Comment 18
Updated by Adam Dingle over 3 years ago
Philip,
I've now tried this latest patch and it runs without crashing. This is still looking very promising. If we don't want the subitems to have icons, I think we could simply use an invisible (i.e. completely transparent) icon for those items – with your latest code I think everything would be nicely indented in that case. Still, it does look pleasing to have icons everwhere. So I think we need to decide the following:
- Should every subitem have an icon? If so, what should they look like?
- Which icon should we use for Photos – the Shotwell icon or the emblem-photos icon?
- What should the Last Import and Tags icons look like? If we need custom icons for these, who is going to design them?
I'll discuss with the Shotwell team here at GUADEC (we're in the Netherlands!) soon.
By the way, the patch is once again out of date with respect to the latest trunk – would be nice to bring it up to date. :) Thanks!
Comment 19
Updated by Adam Dingle over 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 20
Updated by Jim Nelson over 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done set to 100
Hi Philip,
This adds a great deal of polish to Shotwell. We've decided to commit this -- there may be further work in the future fine-tuning the icons.
Cheers!
Comment 21
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:41 UTC ---
This bug was previously known as bug 295 at http://redmine.yorba.org/show_bug.cgi?id=295 Imported an attachment (id=261510)
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED