Fail to build with LibRaw 0.15
Submitted by an unknown user
Link to original bug (#719239)
Description
---- Reported by shotwell-maint@gnome.bugs 2013-05-28 08:09:00 -0700 ----
Original Redmine bug id: 7012
Original URL: http://redmine.yorba.org/issues/7012
Searchable id: yorba-bug-7012
Original author: Luca Falavigna
Original description:
Shotwell fails to build with LibRaw 0.15, recently released.
This is probably because dcraw_document_mode_processin APIs have been removed upstream:
http://www.libraw.org/news/libraw-0-15-0
Related issues:
- related to shotwell - Task #7019: Update libraw.vapi and GRaw (Open)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-29 11:56:00 -0700 ----
History
Comment 1
Updated by Jim Nelson 6 months ago
- Category set to raw
- Target version set to 0.15.0
Thanks for letting us know!
Comment 2
Updated by Joe Bylund 6 months ago
If Shotwell never uses document mode I might lean towards removing references to it (even if the libraw version supports it). Alternatively we could add another pkg-config check in the configure script and conditionally compile the references to document mode, but that seems like extra complication for something shotwell never uses. Thoughts?
Comment 3
Updated by Jim Nelson 6 months ago
- Status changed from Open to Fixed
Applied in changeset 89aa1677.
Comment 4
Updated by Jim Nelson 6 months ago
Yeah, that's all it was. I've removed all references to document-mode, which we weren't actually using.
We haven't updated our LibRaw interface in a while. We should do a code review and see if anything significant has changed we can take advantage of: #7019.
--- Bug imported by chaz@yorba.org 2013-11-25 22:11 UTC ---
This bug was previously known as bug 7012 at http://redmine.yorba.org/show_bug.cgi?id=7012
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.15.0
Resolution: RESOLVED FIXED