straighten in picture editing
Submitted by an unknown user
Link to original bug (#719120)
Description
---- Reported by shotwell-maint@gnome.bugs 2013-10-14 11:09:00 -0700 ----
Original Redmine bug id: 7631
Original URL: http://redmine.yorba.org/issues/7631
Searchable id: yorba-bug-7631
Original author: David Raymond
Original description:
After drawing the line that rotates the picture, hitting the straighten button transforms the picture as presented back to its unstraightened form. However, the straightening really has been done, as can be verified by moving to another picture and moving back. Hitting the straighten button shouldn't put the picture back into its unstraightened form. (Note that just drawing the line rotates the picture, which I think is a change from previous behavior.)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-11-18 07:04:00 -0800 ----
History
Comment 1
Updated by Jim Nelson 29 days ago
- Status changed from Open to Need Information
I can't reproduce this. What version of Shotwell are you using?
Comment 2
Updated by David Raymond 28 days ago
I am using shotwell 0.15.0 on Arch linux.
Dave Raymond
On Wed, Oct 23, 2013 at 5:49 PM, redmine@redmine.yorba.org wrote:
Issue #7631 has been updated by Jim Nelson.
Status changed from Open to Need Information
I can't reproduce this. What version of Shotwell are you using?
7631: straighten in picture editing
http://redmine.yorba.org/issues/7631#change-35406
Author: David Raymond
Status: Need Information
Priority: Normal
Assignee:
Category:
Target version:
Keywords:
After drawing the line that rotates the picture, hitting the straighten
button transforms the picture as presented back to its unstraightened form.
However, the straightening really has been done, as can be verified by
moving to another picture and moving back. Hitting the straighten button
shouldn't put the picture back into its unstraightened form. (Note that
just drawing the line rotates the picture, which I think is a change from
previous behavior.)
--
You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://redmine.yorba.org/my/account
Comment 3
Updated by Joe Bylund 28 days ago
I've observed some weirdness in straightening before, I think for me it was that the photo didn't update after drawing a line on it. But paging forward and then back would show the updated image. I noticed:
./src/Photo.vala:2933: notify_altered(new Alteration("image", "straighen"));
and wondered if that typo had something to do with it.
Comment 4
Updated by Jim Nelson 28 days ago
Believe it or not, it might but it might not -- the Alteration signal being fired should be enough for the image to be redrawn. Not that we shouldn't fix that problem, but it's not a guarantee that it's the root of this issue.
Joe, David, is this something you can reproduce reliably? Does it only happen with portrait or landscape photos? Anything to make this reproducible really helps.
Comment 5
Updated by David Raymond 28 days ago
The problem happens reliably, portrait or landscape.
It also happens whether the desired rotation is specified
by drawing a line or by using the arrow keys to produce
a rotation.
Dave
On Thu, Oct 24, 2013 at 9:21 AM, redmine@redmine.yorba.org wrote:
Issue #7631 has been updated by Jim Nelson.
Believe it or not, it might but it might not -- the Alteration signal
being fired should be enough for the image to be redrawn. Not that we
shouldn't fix that problem, but it's not a guarantee that it's the root of
this issue.
Joe, David, is this something you can reproduce reliably? Does it only
happen with portrait or landscape photos? Anything to make this
reproducible really helps.
7631: straighten in picture editing
http://redmine.yorba.org/issues/7631#change-35411
Author: David Raymond
Status: Need Information
Priority: Normal
Assignee:
Category:
Target version:
Keywords:
After drawing the line that rotates the picture, hitting the straighten
button transforms the picture as presented back to its unstraightened form.
However, the straightening really has been done, as can be verified by
moving to another picture and moving back. Hitting the straighten button
shouldn't put the picture back into its unstraightened form. (Note that
just drawing the line rotates the picture, which I think is a change from
previous behavior.)
--
You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://redmine.yorba.org/my/account
Comment 6
Updated by Jim Nelson 24 days ago
Joe, I've pushed the change you caught. Thanks.
David, are you comfortable pulling Shotwell from our git master, building and running it? As I said, I don't know that this fix will solve your problem, but it might.
Comment 7
Updated by David Raymond 3 days ago
Sorry for the delay, I've been really busy.
I built Shotwell from the git master and it did not solve the
problem.
Dave
On Mon, Oct 28, 2013 at 7:05 PM, redmine@redmine.yorba.org wrote:
Issue #7631 has been updated by Jim Nelson.
Joe, I've pushed the change you caught. Thanks.
David, are you comfortable pulling Shotwell from our git master, building
and running it? As I said, I don't know that this fix will solve your
problem, but it might.
7631: straighten in picture editing
http://redmine.yorba.org/issues/7631#change-35488
Author: David Raymond
Status: Need Information
Priority: Normal
Assignee:
Category:
Target version:
Keywords:
After drawing the line that rotates the picture, hitting the straighten
button transforms the picture as presented back to its unstraightened form.
However, the straightening really has been done, as can be verified by
moving to another picture and moving back. Hitting the straighten button
shouldn't put the picture back into its unstraightened form. (Note that
just drawing the line rotates the picture, which I think is a change from
previous behavior.)
--
You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://redmine.yorba.org/my/account
--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC ---
This bug was previously known as bug 7631 at http://redmine.yorba.org/show_bug.cgi?id=7631
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution CC member joseph.bylund+shotwell@gmail.com does not have an account here
Resolution: RESOLVED FIXED