Selected folders in sidebar folder tree should recursively display all contents
Submitted by Lucas Beeler
Link to original bug (#719090)
Description
---- Reported by lucas@yorba.org 2013-01-11 17:14:00 -0800 ----
Original Redmine bug id: 6211
Original URL: http://redmine.yorba.org/issues/6211
Searchable id: yorba-bug-6211
Original author: Lucas Beeler
Original description:
Imagine that you have following directory structure on disk:
Pictures
|
+--- 2011
| |
| +-- March
| |
| +-- April
|
+--- 2012
Right now, when you select the folder "2011" in the sidebar you will see a blank CollectionPage with the message "No photos/videos" in the main application pane. This is jarring for users. When I first saw the message, I thought to myself "What! I took photos in 2011! Where did they go?"
The reason this happens is that, given the way the sidebar folders tree is implemented today, selecting a folder will display only its immediate children in the CollectionPage in the main pane. So even if you have 20 JPEG files in 2011/March/ and 30 JPEG files in 2011/April/, these are not shown when you select "2011" since these files are not immediate children of 2011/ but are instead children of one of its subdirectories.
This is counterintuitive. We should change the sidebar folder tree such that when a folder is selected all managed photo files in all descendant folders of the selected folder are enumerated recursively and shown together in the CollectionPage in the main pane.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Joe Bylund 10 months ago
- File issue_6211.patch added
- % Done changed from 0 to 10
Patch recursively includes directory contents. Again, zero vala experience, so let me know if there's anything I can change (even if just cosmetic or convention).
Thanks for implementing the folder view, it's super helpful.
Rereading the issue description, maybe in the future it would be better to implement this as a top down thing?
Comment 2
Updated by Jim Nelson 10 months ago
- Status changed from Open to Review
Thanks for the patch, Joseph. Lucas, please review!
Comment 3
Updated by Anonymous 10 months ago
- Status changed from Review to 5
Applied in changeset e933a37e.
Comment 4
Updated by Lucas Beeler 10 months ago
- Resolution set to fixed
Comment 5
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC ---
This bug was previously known as bug 6211 at http://redmine.yorba.org/show_bug.cgi?id=6211 Imported an attachment (id=262677)
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. The original submitter of attachment 262677 was joseph.bylund+shotwell@gmail.com, but he doesn't have an account here. Reassigning to the person who moved it here: chaz@yorba.org.
Version: 0.14.0
Resolution: RESOLVED FIXED