The JPEG part of a RAW+JPEG pair is inappropriately deleted after trashing the photo, then expunging the trash.
Submitted by cli..@..ba.org
Assigned to cli..@..ba.org
Link to original bug (#719081)
Description
---- Reported by clinton@yorba.org 2013-01-18 18:11:00 -0800 ----
Original Redmine bug id: 6238
Original URL: http://redmine.yorba.org/issues/6238
Searchable id: yorba-bug-6238
Original author: Clinton Rogers
Original description:
Steps to reproduce:
- Import a RAW+JPEG paired image into Shotwell.
- Switch the developer for the image from step one from Shotwell to Camera.
- Move the image from step one to the trash.
- Choose Empty Trash.
- Choose Trash Files.
- When prompted to delete the untrashable file, choose OK.
- Navigate to where the image was imported to (usually
~/Pictures/YYYY/MM/DD/
) and observe the results.
Notice that the camera-raw-format file (for example, AAAA1111.CR2) is still there, but its paired JPEG (AAAA1111.JPG) has been deleted, leading to user data loss.
Related issues:
- related to shotwell - 4207: RAW files in RAW+JPEG pairs aren't properly deleted (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Clinton Rogers 10 months ago
- Status changed from Open to Review
Please look at the branch [bug/6238-inappropriate-jpeg-deletion SHA fd84386d09 a11e8ef9829ff029119b4bf20169dc](http://redmine.yorba.org/projects/shotwell/rep ository/revisions/fd84386d09a11e8ef9829ff029119b4bf20169dc) for a fix for this; in a nutshell, if we get into delete_raw_development() with an argument of RawDeveloper.CAMERA, then we know it's a user-generated development file and trash it instead of deleting it; SHOTWELL and EMBEDDED developments are still deleted outright, in accordance with the original design.
Comment 2
Updated by Clinton Rogers 10 months ago
- % Done changed from 0 to 40
Comment 3
Updated by Lucas Beeler 10 months ago
- Status changed from Review to Open
Needs more work. I get a "can't delete file error" when I delete a photo comprising a RAW+JPEG with the RAW developer set to "Camera."
Comment 4
Updated by Clinton Rogers 10 months ago
- Status changed from Open to Review
- Assignee set to Clinton Rogers
- % Done changed from 40 to 70
Please see http://redmine.yorba.org/issues/4207#note-16 regarding this; the branch revision in question should solve this as well.
Comment 5
Updated by Clinton Rogers 10 months ago
- Status changed from Review to 5
Applied in changeset 82f70dd6.
Comment 6
Updated by Clinton Rogers 10 months ago
- % Done changed from 70 to 100
- Resolution set to fixed
Comment 7
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC ---
This bug was previously known as bug 6238 at http://redmine.yorba.org/show_bug.cgi?id=6238
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.14.0
Resolution: RESOLVED FIXED