"OK" button in edit tags and edit title dialog should be titled "Save"
Submitted by Lucas Beeler
Assigned to Lucas Beeler
Link to original bug (#719070)
Description
---- Reported by lucas@yorba.org 2013-01-25 12:30:00 -0800 ----
Original Redmine bug id: 6262
Original URL: http://redmine.yorba.org/issues/6262
Searchable id: yorba-bug-6262
Original author: Lucas Beeler
Original description:
According to the GNOME Human Interface Guidelines (http://developer.gnome.org /hig-book/3.5/controls-buttons.html.en), buttons should be labeled with an imperative verb that names the action taken in response to their being pushed. Since the action the "OK" button effects in both of these cases is to save the tag or title information, this button should be labeled "Save."
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Joe Bylund 9 months ago
- File issue_6262.patch added
- % Done changed from 0 to 10
Comment 2
Updated by Jim Nelson 9 months ago
- Status changed from Open to Review
Thanks!
Comment 3
Updated by Anonymous 9 months ago
- Status changed from Review to 5
Applied in changeset aae8ca3b.
Comment 4
Updated by Lucas Beeler 9 months ago
- Assignee set to Lucas Beeler
- Resolution set to fixed
Comment 5
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC ---
This bug was previously known as bug 6262 at http://redmine.yorba.org/show_bug.cgi?id=6262 Imported an attachment (id=262670)
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. The original submitter of attachment 262670 was joseph.bylund+shotwell@gmail.com, but he doesn't have an account here. Reassigning to the person who moved it here: chaz@yorba.org.
Version: 0.14.0
Resolution: RESOLVED FIXED