Piwigo sharing: support comments
Submitted by an unknown user
Link to original bug (#719064)
Description
---- Reported by shotwell-maint@gnome.bugs 2013-01-28 14:45:00 -0800 ----
Original Redmine bug id: 6272
Original URL: http://redmine.yorba.org/issues/6272
Searchable id: yorba-bug-6272
Original author: Norbert Preining
Original description:
Now that comments are supported, piwigo connector should be adapted to upload them
Related issues:
- related to shotwell - Feature #1573 (closed): add notes/description to photo (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Jim Nelson 10 months ago
- Category set to web-sharing
Comment 2
Updated by Norbert Preining 10 months ago
- File upload-comment-piwigo.patch added
Hi
here a patch for that. It changes the semantics of the formerly introduced title-as-comment setting slightly:
Before comments support: if title was set, use it as comment
After comments support (now): if title is set and comment unset, use title as comment on upload to piwigo
this is for backward compatibility for those that have used the titles till now to specify the comment.
Comment 3
Updated by Norbert Preining 10 months ago
Branch also available at
https://bitbucket.org/preining/shotwell.git 6272-piwigo-comments
Comment 4
Updated by Jim Nelson 10 months ago
- Status changed from Open to Review
- Target version set to 0.14.0
Thanks, Norbert!
Comment 5
Updated by Lucas Beeler 9 months ago
- Status changed from Review to Open
Overall this patch looks good, but I can see at least one change that needs to be made. In your patch, at PublishingInterfaces.vala:541, you add a new method, get_publishing_comment(), to the Publishable interface used by the entire publishing subsystem. In general, we don't like adding top-level accessor methods to Publishable (or any other interface used by the entire publishing subsystem) unless virtually all Publishable objects have the accessed property and unless virtually all services support the property. This is not the case for comments. For secondary information like comments and the basename of the file being published, we have another information access mechanism: the get_param_* methods. These methods are named for the type of object that they return (e.g., get_param_string()) and they take a string- valued lookup key as their sole argument. To allow checking the value of the string argument at compile time, all of these lookup keys are also defined as symbolic constants. So what you need to do is add a new string constant called something like PARAM_STRING_COMMENT at PublishingInterfaces.vala:517 where the rest of the PARAM_STRING constants are defined then modify the MediaSourcePublishableWrapper class's setup_parameters() method so that it knows about the new string parameter. The setup_parameters() method of class MediaSourcePublishableWrapper can be found at APIGlue.vala:35.
Make these changes and send us an updated patch!
Comment 6
Updated by Norbert Preining 9 months ago
- File piwigo-comments-20130212.patch added
Here is a fixed patch, thanks for the insightful comments!
Norbert
Comment 7
Updated by Jim Nelson 9 months ago
- Status changed from Open to Review
- Assignee set to Norbert Preining
Thanks Norbert!
Comment 8
Updated by Lucas Beeler 9 months ago
- Status changed from Review to 5
- Resolution set to fixed
Implemented in changeset commit 0c9b9a38.
Comment 9
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC ---
This bug was previously known as bug 6272 at http://redmine.yorba.org/show_bug.cgi?id=6272 Imported an attachment (id=262659) Imported an attachment (id=262660)
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.14.0
Resolution: RESOLVED FIXED