Rotating, externally editing with certain editors, then reverting a JPEG causes its orientation to be reset inappropriately.
Submitted by cli..@..ba.org
Assigned to cli..@..ba.org
Link to original bug (#719019)
Description
---- Reported by clinton@yorba.org 2013-02-25 18:57:00 -0800 ----
Original Redmine bug id: 6430
Original URL: http://redmine.yorba.org/issues/6430
Searchable id: yorba-bug-6430
Original author: Clinton Rogers
Original description:
Steps to reproduce:
- Import an image that was taken with the camera held in portrait position or rotate an existing JPEG image to anything other than 'top-left'.
- Set GIMP as the external editor.
- Choose to externally edit the image from step one.
- When GIMP asks if it should rotate the image to standard orientation, choose yes.
- Modify and save the image.
- In Shotwell, revert the image, choosing yes when it asks if it should discard external edits.
Notice that the reverted image is now oriented 'top-left', rather than what it was originally oriented as.
Related issues:
- related to shotwell - 1938: Rotation confusion when another app has rotated and resaved (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:47:00 -0700 ----
History
Comment 1
Updated by Clinton Rogers 9 months ago
- Assignee set to Clinton Rogers
- Target version set to 0.14.0
Comment 2
Updated by Jim Nelson 9 months ago
- Category changed from import to library-mode
Clinton, is this the bug we discussed earlier that required metadata writing to be enabled?
Comment 3
Updated by Clinton Rogers 9 months ago
- % Done changed from 0 to 10
Yes it is; for those playing along at home, metadata writing has to be turned on to encounter the problem.
Comment 4
Updated by Clinton Rogers 9 months ago
- Status changed from Open to Review
- % Done changed from 10 to 80
Comment 5
Updated by Lucas Beeler 9 months ago
- Status changed from Review to Open
Review: redo. We need to special-case orientation as discussed.
Comment 6
Updated by Clinton Rogers 9 months ago
- Status changed from Open to Review
- % Done changed from 80 to 90
Revised per discussion with Lucas; here's what's different:
Instead of not touching the master at all, we now skip writing the orientation if there's an editable, but we do write other metadata that should be preserved and synced, such as tags, title, rating, etc.
Verified that I can externally edit an image, title or tag it, rate it, then revert the changes and have my title, tags and rating persist.
Comment 7
Updated by Lucas Beeler 9 months ago
Review: approve. Commit!
Comment 8
Updated by Clinton Rogers 9 months ago
- Status changed from Review to 5
Applied in changeset 26bd2b05.
Comment 9
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC ---
This bug was previously known as bug 6430 at http://redmine.yorba.org/show_bug.cgi?id=6430
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.14.0
Resolution: RESOLVED FIXED