comments containing html code are uploaded with mark up stripped
Submitted by an unknown user
Link to original bug (#719012)
Description
---- Reported by shotwell-maint@gnome.bugs 2013-02-27 18:57:00 -0800 ----
Original Redmine bug id: 6449
Original URL: http://redmine.yorba.org/issues/6449
Searchable id: yorba-bug-6449
Original author: Norbert Preining
Original description:
Currently, if comments (of photos or events) contain markup (html), that is handled properly on display as text, but during upload the markup is stripped. This is not what it should be. I assign this to myself.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:45:00 -0700 ----
History
Comment 1
Updated by Jim Nelson 9 months ago
- Category set to web-sharing
- Status changed from Open to Need Information
Where are you planning on dealing with this? I ask because there's no guarantee that every web service will deal with markup properly. Piwigo might, for example, but we can't assume other services do.
Comment 2
Updated by Norbert Preining 9 months ago
I would say we keep that to the users responsability. The user has to know what to write. For example I know that I can upload html code to my piwigo albums, so I will use some markup in the comment and upload it.
If I would use primarly facebook, which (AFAIK) does not support html markup, I would not put markup into the comment, or delete it before uploading.
I would keep that solely to the user. WE cannot know. There might be services that require xml markup, or whatever special thing. Best is in my opinion to treat the comments as opaque strings.
What do you think?
Comment 3
Updated by Norbert Preining 9 months ago
Actually, I see now that this already works for photo comments. I must have messed up something in the album comments upload and strip too much. Fix should be easy.
Comment 4
Updated by Norbert Preining 9 months ago
Actually, the more I look into it it looks like a bug in piwigo, namely that the pwg.categories.add call strips the html code, and not shotwell. Puaahhh, going to the Piwigo forum.
Comment 5
Updated by Norbert Preining 9 months ago
- Resolution set to invalid
Set to invalid, this is an upstream bug that has been fixed in their svn now after I asked back.
See:
http://piwigo.org/bugs/view.php?id=2852
http://piwigo.org/forum/viewtopic.php?id=21518
Norbert
Comment 6
Updated by Lucas Beeler 9 months ago
- Status changed from Need Information to 5
Comment 7
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Invalid
--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC ---
This bug was previously known as bug 6449 at http://redmine.yorba.org/show_bug.cgi?id=6449
Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED INVALID