Shotwell does not build with Vala master
Submitted by an unknown user
Link to original bug (#718893)
Description
---- Reported by shotwell-maint@gnome.bugs 2012-08-06 06:56:00 -0700 ----
Original Redmine bug id: 5619
Original URL: http://redmine.yorba.org/issues/5619
Searchable id: yorba-bug-5619
Original author: J ürg Billeter
Original description:
None
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 1 year ago
- Priority changed from Normal to Urgent
- Target version set to 0.13
Thanks for letting us know, Jürg. We'll look at this immediately since we really want Shotwell to build with the upcoming Vala release.
Comment 2
Updated by Jürg Billeter over 1 year ago
- File 0001-Do-not-access-static-members-with-instance-reference.patch added
The attached patch fixes build with Vala master. It was broken due to https://bugzilla.gnome.org/show_bug.cgi?id=661034 being fixed and Shotwell's use of --fatal-warnings.
Comment 3
Updated by Adam Dingle over 1 year ago
- Status changed from Open to Review
Lucas, please review - thanks!
Comment 4
Updated by Adam Dingle over 1 year ago
- Status changed from Review to 5
- Resolution set to fixed
This looks fine. Committed. Thanks, Jürg!
Comment 5
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:58 UTC ---
This bug was previously known as bug 5619 at http://redmine.yorba.org/show_bug.cgi?id=5619 Imported an attachment (id=262587)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED