[interim] stop using Gtk.Table
Submitted by Adam Dingle
Assigned to cli..@..ba.org
Link to original bug (#718831)
Description
---- Reported by adam@yorba.org 2012-09-18 13:25:00 -0700 ----
Original Redmine bug id: 5838
Original URL: http://redmine.yorba.org/issues/5838
Searchable id: yorba-bug-5838
Original author: Adam Dingle
Original description:
We had to turn on --enable-deprecated late in the 0.13 development cycle since we use Gtk.Table which has now been deprecated. See #5803. For 0.14, we should stop using Gtk.Table so that we no longer need to build with --enable- deprecated.
Related issues:
- related to shotwell - 5803: can't build with vala trunk (Gtk.Table deprecation warning) (Fixed)
- related to shotwell - 6192: Remove --enable-experimental from Makefile (Open)
- related to shotwell - 6893: Remove '--enable-deprecated' from the Makefile (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 18:24:00 -0700 ----
History
Comment 1
Updated by Adam Dingle about 1 year ago
- Assignee set to Clinton Rogers
Comment 2
Updated by Clinton Rogers about 1 year ago
- % Done changed from 0 to 10
Comment 3
Updated by Jim Nelson 11 months ago
- Category set to ux
Comment 4
Updated by Jim Nelson 11 months ago
- Category changed from ux to build
Comment 5
Updated by Jim Nelson 11 months ago
-
Assignee deleted (
<strike>
_Clinton Rogers_</strike>
)
Comment 6
Updated by Jim Nelson 9 months ago
- Target version changed from 0.14.0 to 0.15.0
Comment 7
Updated by Lucas Beeler 8 months ago
- Subject changed from stop using Gtk.Table to [interim] stop using Gtk.Table
Comment 8
Updated by Jim Nelson 8 months ago
- Assignee set to Clinton Rogers
Comment 9
Updated by Clinton Rogers 8 months ago
- Status changed from Open to Review
- % Done changed from 10 to 20
Comment 10
Updated by Clinton Rogers 7 months ago
- % Done changed from 20 to 30
Comment 11
Updated by Clinton Rogers 7 months ago
- % Done changed from 30 to 40
Comment 12
Updated by Lucas Beeler 7 months ago
Okay, Clint. Go ahead and commit the portion of your patch that you've stashed in bug/5838-switch-extended-info-dlog-away-from-table.
Comment 13
Updated by Lucas Beeler 7 months ago
Clint, I'm rejecting your patch on branch bug/5838-switch-export-dlog-away- from-table. The new dialog has different spacing and margins than the old dialog, and since it's more compressed, it looks uglier. A key requirement for all of these tickets about switching to Gtk.Grid is that the appearance of the dialog not change. It doesn't have to be pixel-for-pixel perfect, but it should be close.
Comment 14
Updated by Clinton Rogers 7 months ago
Sorry for the mixup, for the slideshow settings dialog, please look at [origin/bug/5838-slideshow-settings-dlog-gladified SHA 6fa398546f7a81e682398ed 2896290069471fecb](http://redmine.yorba.org/projects/shotwell/repository/revis ions/6fa398546f7a81e682398ed2896290069471fecb) .
Comment 15
Updated by Lucas Beeler 7 months ago
- Status changed from Review to Open
Clint, on branch bug/5838-slideshow-settings-dlog-gladified, could we get some additional padding around the outside edge of the dialog. It looks awkward to have text run right up to the window edge. I know our old, programmatic version of the dialog had the same problem (albeit to a lesser extent), but the cool thing about having these in Glade is that we can fix them with the touch of a button! Make this change and update the branch!
Comment 16
Updated by Clinton Rogers 7 months ago
Please re-pull from this branch - horizontal margins of 8px have been added to both sides of the enclosing pane.
Comment 17
Updated by Clinton Rogers 7 months ago
- Status changed from Open to Review
Comment 18
Updated by Lucas Beeler 7 months ago
- Status changed from Review to Open
Okay. That's dramatically better. Go ahead and commit the code on branch bug/5838-slideshow-settings-dlog-gladified. I'm going to set the ticket status back to open. When you finish your next iteration of the changeset on branch bug/5838-switch-export-dlog-away-from-table, set it back to review!
Comment 19
Updated by Clinton Rogers 7 months ago
- % Done changed from 40 to 60
Per Lucas in comment 18, just added 7792fc4f to master.
Comment 20
Updated by Clinton Rogers 7 months ago
- Status changed from Open to Review
Comment 21
Updated by Clinton Rogers 7 months ago
Please use 94f36705056d53c79cc8f51354236b2e20be3ece instead - it adds better spacing around the widgets.
Comment 22
Updated by Lucas Beeler 7 months ago
- Status changed from Review to Open
Review of latest iteration: approve. Commit the new export dialog. After this, how much more do we need to do before we can rip --enable-deprecated out of the Makefile?
Comment 23
Updated by Clinton Rogers 7 months ago
12c82634 has been added to master for the export dialog.
@Lucas: one more, it's the adjustment tool window; I expect to have it handed in sometime during the morning of 2013-05-01.
Comment 24
Updated by Clinton Rogers 7 months ago
- % Done changed from 60 to 80
Please review f8c27c1e001b50993e9d93e62af0177c373389dd for the colour-adjust tool. There are very subtle differences between it and the original - namely slightly wider margins, but in return, everything is now centered and stays that way under a variety of fonts and widget themes (the previous one had certain combos that could misalign it).
Comment 25
Updated by Clinton Rogers 7 months ago
- Status changed from Open to Review
Comment 26
Updated by Lucas Beeler 7 months ago
- Status changed from Review to Open
Comment 27
Updated by Clinton Rogers 7 months ago
- Status changed from Open to Review
8ef6ec5a has all the layout changes we discussed; setting back to review.
Comment 28
Updated by Clinton Rogers 7 months ago
- Status changed from Review to Fixed
- % Done changed from 80 to 100
This fixes the widgets, but does NOT fix all deprecation warnings.
--- Bug imported by chaz@yorba.org 2013-11-25 21:58 UTC ---
This bug was previously known as bug 5838 at http://redmine.yorba.org/show_bug.cgi?id=5838
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.15.0
Resolution: RESOLVED FIXED