configure doesn't handle multiple invalid options properly
Submitted by Jim Nelson
Assigned to cli..@..ba.org
Link to original bug (#718775)
Description
---- Reported by jim@yorba.org 2012-10-22 15:42:00 -0700 ----
Original Redmine bug id: 6015
Original URL: http://redmine.yorba.org/issues/6015
Searchable id: yorba-bug-6015
Original author: Jim Nelson
Original description:
This will fail:
$ ./configure --disable-schemas-install
However, this succeeds:
$ ./configure --prefix=/usr --disable-schemas-install
Looking at the script file, I suspect the issue is that $value isn't being cleared each iteration through the argument processing loop.
Related issues:
- related to shotwell - 6016: gschemas.compiled is installed in packaging (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Jim Nelson 11 months ago
- Category set to build
- Assignee set to Clinton Rogers
Comment 2
Updated by Clinton Rogers 11 months ago
- File 6015.diff added
- Status changed from Open to Review
- % Done changed from 0 to 70
Comment 3
Updated by Clinton Rogers 11 months ago
Please note that this will only catch improperly-formatted arguments, but not bogus ones; if I type something like
./configure --qbert=coily
...it will still cheefully accept this, even though we don't look for an argument with that name.
Comment 4
Updated by Clinton Rogers 11 months ago
-
File deleted (
<strike>
_6015.diff_</strike>
)
Comment 5
Updated by Clinton Rogers 11 months ago
- File 6015_catch_bogus_args.diff added
- % Done changed from 70 to 80
Here's a second pass at this that catches bogus arguments, too, regardless of what order they're passed in or how many legitimate arguments come before it.
Comment 6
Updated by Jim Nelson 11 months ago
To restate what I talked about with Clinton, the configure script can accept unknown arguments, as long as they don't begin with two dashes. These arguments are treated as Make variables by Makefile. The only parameters that should be checked for validity are those that start with two dashes.
Comment 7
Updated by Clinton Rogers 11 months ago
-
File deleted (
<strike>
_6015_catch_bogus_args.diff_</strike>
)
Comment 8
Updated by Clinton Rogers 11 months ago
- File 6015_catch_bogus_args_but_allow_makefile_vars.diff added
Here's the end result; we now catch bogus arguments beginning with '--', but accept arguments of the form 'SOME_OPTION=SOME_VALUE'; the latter get appended to configure.mk as desired.
Comment 9
Updated by Lucas Beeler 11 months ago
Commit!
Comment 10
Updated by Clinton Rogers 11 months ago
- Status changed from Review to 5
Applied in changeset cf7132f1.
Comment 11
Updated by Clinton Rogers 11 months ago
- % Done changed from 80 to 100
- Resolution set to fixed
Comment 12
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:58 UTC ---
This bug was previously known as bug 6015 at http://redmine.yorba.org/show_bug.cgi?id=6015 Imported an attachment (id=262517)
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.14.0
Resolution: RESOLVED FIXED