Add Tag and Modify Tag do not work
Submitted by an unknown user
Assigned to cli..@..ba.org
Link to original bug (#718657)
Description
---- Reported by shotwell-maint@gnome.bugs 2012-04-16 12:43:00 -0700 ----
Original Redmine bug id: 5066
Original URL: http://redmine.yorba.org/issues/5066
Searchable id: yorba-bug-5066
Original author: Laura Khalil
Original description:
To reproduce:
Either -- select Add Tags from the drop down menu OR right click on a photo and select Add Tags.
Notice effect.
Shotwell does not respond to "Modify Tags" either.
Related issues:
- related to shotwell - 4501: Can't use Glade 3.10.2 with Shotwell (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Laura Khalil over 1 year ago
- Subject changed from New Tag and Modify Tag do not work to Add Tag and Modify Tag do not work
Comment 2
Updated by Clinton Rogers over 1 year ago
- Category set to 4
- Assignee set to Clinton Rogers
- Priority changed from Normal to Urgent
Comment 3
Updated by Clinton Rogers over 1 year ago
- % Done changed from 0 to 20
Traced this issue as far as [AddTagsDialog](http://git.yorba.org/cgit.cgi/shot well/tree/src/Dialogs.vala#n1581) 's constructor.
Comment 4
Updated by Clinton Rogers over 1 year ago
- % Done changed from 20 to 30
Most likely, this is an issue with ui/shotwell.glade - presumably, there's something wonky about the TextEntryDialog definition's syntax, and as a result, it's silently refusing to let us instantiate a new one.
Comment 5
Updated by Clinton Rogers over 1 year ago
- File 5066.diff added
- Status changed from Open to Review
- % Done changed from 30 to 70
Comment 6
Updated by Adam Dingle over 1 year ago
- Target version set to 0.13
Good catch, Laura.
Comment 7
Updated by Clinton Rogers over 1 year ago
- Status changed from Review to 5
- % Done changed from 70 to 100
- Resolution set to fixed
What was happening is that we were trying to get a Gtk.Dialog as a TextEntryDialog, and this is considered an unsafe cast, so 'dialog' would be null after the call.
Changing the object type in the .glade file fixes the application, but makes Glade unhappy again; there doesn't seem to be any (straightforward?) way of telling Glade that TextEntryDialog should be treated as a child class of Gtk.Dialog, and that it's something that Glade already knows about...
Comment 8
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:57 UTC ---
This bug was previously known as bug 5066 at http://redmine.yorba.org/show_bug.cgi?id=5066 Imported an attachment (id=262471)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED