Tumblr plugin
Submitted by Adam Dingle
Assigned to Lucas Beeler
Link to original bug (#718549)
Description
---- Reported by adam@yorba.org 2012-06-21 09:40:00 -0700 ----
Original Redmine bug id: 5431
Original URL: http://redmine.yorba.org/issues/5431
Searchable id: yorba-bug-5431
Original author: Adam Dingle
Original description:
Jeroen Arnoldus has developed a Tumblr plugin (he sent the source code by email). Lucas, please review!
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Lucas Beeler over 1 year ago
- Assignee set to Lucas Beeler
Hi Jeroen,
I'm Lucas, the Shotwell lead developer. I just wanted to say thank you so much for the patch. I've got a lot on my plate right now, but I should be able to review your changeset sometime next week! Once again, thanks for your contribution.
Lucas
Comment 2
Updated by Lucas Beeler over 1 year ago
Hi Jeroen,
Thank you so much for your patch. It will be great to see a Tumblr connector in Shotwell. I've looked at your code and see a few changes in placement and packaging that need to be made before we get into a deep code review.
First, the Tumblr plugin should be packaged in plugins/shotwell-publishing- extras/ not in plugins/shotwell-publishing. The shotwell-publishing-extras directory is for plugins developed by third parties and not officially supported by Yorba. Note that moving your plugin into shotwell-publishing- extras is slightly more complicated than just moving your source files around. You'll also have to change the way you mark up strings for translation. For more information about how internationalized strings are handled in the Shotwell Extras Plugin Pack, see the "Shotwell Extras Developers" section of the Shotwell Internationalization Guide here: http://redmine.yorba.org/project s/shotwell/wiki/ShotwellInternationalizationGuide.
Second, our preferred way of reviewing outside patches is to review complete diffs generated with either "git diff" or "git format-patch." Once you've prepared a patch, you should attach it to this ticket. Since you have a binary asset that accompanies your patch (i.e., your Tumblr logo PNG image), please use the --binary option when invoking either git diff or git format-patch.
So move your Tumblr plugin code into shotwell-publishing-extras and attach an updated, single-file patch to this ticket. Then I'll be able to comprehensively review it and, hopefully, after a few more review-and-fix iterations, we can get this feature landed!
Lucas
Comment 3
Updated by Lucas Beeler over 1 year ago
- Status changed from Review to Open
Comment 4
Updated by Adam Dingle over 1 year ago
- Status changed from Open to Review
An updated patch is ready for review.
Comment 5
Updated by Adam Dingle over 1 year ago
-
Assignee deleted (
<strike>
_Lucas Beeler_</strike>
)
Comment 6
Updated by Lucas Beeler about 1 year ago
- Category set to 4
- Status changed from Review to 5
- Resolution set to fixed
Committed as d13e876a.
Comment 7
Updated by Adam Dingle about 1 year ago
- Status changed from 5 to Open
- Assignee set to Lucas Beeler
- Priority changed from High to Immediate
-
Resolution deleted (
<strike>
_fixed_</strike>
)
This change broke the build for me at least:
TumblrPublishing.vala:1041.13-1041.20: error: Access to instance member `Publishing.Tumblr.TumblrPublisher.username' denied
username != null);
^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
Comment 8
Updated by Lucas Beeler about 1 year ago
- Status changed from Open to 5
- Resolution set to fixed
Re-fixed in ec0d0b9a.
Comment 9
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:57 UTC ---
This bug was previously known as bug 5431 at http://redmine.yorba.org/show_bug.cgi?id=5431
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED