[norepro] Under rare circumstances, it may be possible to get the application to attempt to create a Dimensions object with a negative width or height.
Submitted by cli..@..ba.org
Assigned to cli..@..ba.org
Link to original bug (#718528)
Description
---- Reported by clinton@yorba.org 2012-07-10 11:32:00 -0700 ----
Original Redmine bug id: 5527
Original URL: http://redmine.yorba.org/issues/5527
Searchable id: yorba-bug-5527
Original author: Clinton Rogers
Original description:
It isn't clear how to reproduce this, but the user in https://bugzilla.redhat.com/show_bug.cgi?id=830610 encountered a problem where Shotwell attempted to create a Dimensions with negative dimensions (which isn't permitted and triggered an assertion).
Instead of asserting here, it may be helpful to force sensible defaults; this will make the app more robust, and by extension, user-friendlier.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 1 year ago
- Subject changed from Under rare circumstances, it may be possible to get the application to attempt to create a Dimensions object with a negative width or height. to [norepro] Under rare circumstances, it may be possible to get the application to attempt to create a Dimensions object with a negative width or height.
Comment 2
Updated by Clinton Rogers over 1 year ago
- File 5527.patch added
Comment 3
Updated by Clinton Rogers over 1 year ago
- Status changed from Open to Review
Comment 4
Updated by Clinton Rogers over 1 year ago
- Status changed from Review to 5
- % Done changed from 70 to 100
- Resolution set to fixed
Comment 5
Updated by Thomas Moschny over 1 year ago
Would it be possible to cherry-pick the commit onto the 0.12 branch also?
Comment 6
Updated by Clinton Rogers over 1 year ago
Thomas Moschny wrote:
Would it be possible to cherry-pick the commit onto the 0.12 branch also?
This was done as of Friday, 2012-07-13.
Comment 7
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:57 UTC ---
This bug was previously known as bug 5527 at http://redmine.yorba.org/show_bug.cgi?id=5527 Imported an attachment (id=262387)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED