Shotwell's libgphoto2.vapi needs updating for libgphoto2 2.5.0
Submitted by an unknown user
Assigned to cli..@..ba.org
Link to original bug (#718521)
Description
---- Reported by shotwell-maint@gnome.bugs 2012-07-14 09:01:00 -0700 ----
Original Redmine bug id: 5553
Original URL: http://redmine.yorba.org/issues/5553
Searchable id: yorba-bug-5553
Original author: Michel Alexandre Salim
Original description:
The newly-released libgphoto2 2.5.0 contains some API incompatibilities (see http://gphoto.org/news/) that causes Shotwell 0.12.3 (plus the src/sidebar/Tree.vala patch for #5453) to fail to build:
http://kojipkgs.fedoraproject.org//work/tasks/9606/4239606/build.log
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:289:6: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:289:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:289:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:6: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:295:22: error: request for member 'path' in something not a structure or union
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:297:24: error: request for member 'path' in something not a structure or union
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:287:6: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:287:6: warning: statement with no effect [-Wunused-value]
CameraTable.c:2781:16: warning: variable 'tmp100' set but not used [-Wunused-but-set-variable]
CameraTable.c:2778:16: warning: variable 'tmp97' set but not used [-Wunused- but-set-variable]
CameraTable.c:2749:8: warning: unused variable 'camera_collection_size' [-Wunused-variable]
CameraTable.c:2748:8: warning: variable 'camera_collection_length1' set but not used [-Wunused-but-set-variable]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:303:3: warning: passing argument 1 of 'gee_abstract_map_get_keys' from incompatible pointer type [enabled by default]
In file included from src/camera/CameraTable.c:20:0:
/usr/include/gee-1.0/gee.h:792:9: note: expected 'struct GeeAbstractMap **' but argument is of type 'struct GeeMap *'
CameraTable.c:3015:4: warning: missing braces around initializer [-Wmissing- braces]
CameraTable.c:3015:4: warning: (near initialization for 'camera_abilities.model') [-Wmissing-braces]
CameraTable.c:3018:4: warning: missing braces around initializer [-Wmissing- braces]
CameraTable.c:3018:4: warning: (near initialization for 'tmp178.model') [-Wmissing-braces]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:343:5: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:343:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:343:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:346:23: error: request for member 'path' in something not a structure or union
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:350:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:350:8: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:5: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:303:5: warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:303:5: warning: statement with no effect [-Wunused-value]
CameraTable.c:3009:15: warning: variable 'tmp166' set but not used [-Wunused-but-set-variable]
CameraTable.c:2043:7: warning: variable 'usb_cameras_size' set but not used [-Wunused-but-set-variable]
make: **** [src/camera/CameraTable.o] Error 1
Related issues:
- related to shotwell - 5566: Shotwell can't import photos from Android 4 devices (Invalid)
- related to shotwell - 5655: Mass Storage Camera Lumix lx5 does not display thumbnails... (Open)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 1 year ago
- Priority changed from Normal to High
- Target version set to 0.13
Thanks for letting us know, Michel. Shotwell 0.13 may possibly need to support both libgphoto 2.4 and 2.5, depending on whether major distros upgrade to 2.5 in their upcoming releases and on whether they allow 2.4 and 2.5 to be installed in parallel.
Comment 2
Updated by Michel Alexandre Salim over 1 year ago
For completeness, I just verified that the exact same error is given when compiling from the git master (once the additional dependency on json-glib- devel is installed).
Fedora's Rawhide (to be Fedora 18, due out in late November) just moved to libgphoto2 2.5.0, which is how I noticed this change, but if Yorba plans to stick with the 2.4 series, let me know and I can probably introduce a compatibility package.
Comment 3
Updated by Thomas Moschny over 1 year ago
From our perspective, Shotwell switching to libgphoto2 2.5 would be the best.
I have no clue how big the API changes are, though. Would it be possible to support both versions?
Comment 4
Updated by Thomas Moschny over 1 year ago
This becomes sort of urgent for us, see https://bugzilla.redhat.com/show_bug.cgi?id=844510 - Fedora 18 Alpha release is planned for 2012-08-28 (see http://fedoraproject.org/wiki/Releases/18/Schedule).
Can you comment on your plans regarding gphoto2 support?
I had a brief look and it seems there are (at least) some changes required in the camera and port handling code in src/camera/CameraTable.vala. The 'path' field has been removed from the corresponding structs and is now passed directly to the API functions.
Comment 5
Updated by Adam Dingle over 1 year ago
- Priority changed from High to Urgent
Looks like we need to address this in some way soon. Marking as urgent.
Comment 6
Updated by Adam Dingle over 1 year ago
- Assignee set to Clinton Rogers
Looks like we may need to target both libgphoto 2.4 and 2.5 and have a configure switch to choose between them. It would be nice to have this in time for the Fedora alpha release in a couple of weeks. Clint, can you make this happen?
Comment 7
Updated by Clinton Rogers over 1 year ago
- % Done changed from 0 to 30
Patch partially works, but does not automagically detect which version of libgphoto2 is installed on the compilation host.
Comment 8
Updated by Jindrcih Novy over 1 year ago
Roger, could you please attach the patch here to let me test? Thanks!
Comment 9
Updated by Clinton Rogers over 1 year ago
- File 5553-no-version-autodetect-yet.patch added
Hi Jindrcih,
We've put together a patch that should work as expected with both 2.4.x and 2.5.x, and I've attached it above (it supercedes the previous patch).
Please note that, in order for this to work, running configure is now required (it used to be optional; while slightly less convenient, this is consistent with a lot of other larger packages, and provides a tidy place to set things up exactly like the makefile needs them).
Comment 10
Updated by Clinton Rogers over 1 year ago
-
File deleted (
<strike>
_5553-no-version-autodetect-yet.patch_</strike>
)
Comment 11
Updated by Clinton Rogers over 1 year ago
- File 5553-submission-candidate.patch added
- % Done changed from 30 to 70
Comment 12
Updated by Clinton Rogers over 1 year ago
- Status changed from Open to Review
Comment 13
Updated by Lucas Beeler over 1 year ago
Commit!
Comment 14
Updated by Clinton Rogers over 1 year ago
- Category set to 4
- Status changed from Review to 5
- % Done changed from 70 to 100
- Resolution set to fixed
Comment 15
Updated by Clinton Rogers about 1 year ago
- File 0001-Ensure-that-the-changes-made-for-#5553-get-propagated-to-any-tarballs-we-generate.patch added
Hi all,
Can someone approve the attached patch? It's to make sure the new
gphoto2 vapis are appropriately copied when running make dist.
On 21/08/2012, redmine@redmine.yorba.org redmine@redmine.yorba.org wrote:
Issue #5553 has been updated by Lucas Beeler.
Commit!
5553: Shotwell's libgphoto2.vapi needs updating for libgphoto2 2.5.0
http://redmine.yorba.org/issues/5553#change-17899
Author: Michel Alexandre Salim
Status: Review
Priority: Urgent
Assignee: Clinton Rogers
Category:
Target version: 0.13
Resolution:
Keywords:
The newly-released libgphoto2 2.5.0 contains some API incompatibilities (see
http://gphoto.org/news/) that causes Shotwell 0.12.3 (plus the
src/sidebar/Tree.vala patch for #5453) to fail to build:
http://kojipkgs.fedoraproject.org//work/tasks/9606/4239606/build.log
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:289:6:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:289:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:289:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:6:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:293:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:295:22:
error: request for member 'path' in something not a structure or union
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:297:24:
error: request for member 'path' in something not a structure or union
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:287:6:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:287:6:
warning: statement with no effect [-Wunused-value]
CameraTable.c:2781:16: warning: variable 'tmp100' set but not used
[-Wunused-but-set-variable]
CameraTable.c:2778:16: warning: variable 'tmp97' set but not used
[-Wunused-but-set-variable]
CameraTable.c:2749:8: warning: unused variable 'camera_collection_size'
[-Wunused-variable]
CameraTable.c:2748:8: warning: variable 'camera_collection_length1' set but
not used [-Wunused-but-set-variable]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:303:3:
warning: passing argument 1 of 'gee_abstract_map_get_keys' from incompatible
pointer type [enabled by default]
In file included from src/camera/CameraTable.c:20:0:
/usr/include/gee-1.0/gee.h:792:9: note: expected 'struct GeeAbstractMap **'
but argument is of type 'struct GeeMap *'
CameraTable.c:3015:4: warning: missing braces around initializer
[-Wmissing-braces]
CameraTable.c:3015:4: warning: (near initialization for
'camera_abilities.model') [-Wmissing-braces]
CameraTable.c:3018:4: warning: missing braces around initializer
[-Wmissing-braces]
CameraTable.c:3018:4: warning: (near initialization for 'tmp178.model')
[-Wmissing-braces]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:343:5:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:343:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:343:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:346:23:
error: request for member 'path' in something not a structure or union
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:350:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:350:8:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:5:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:353:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:357:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:358:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:359:7:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:303:5:
warning: statement with no effect [-Wunused-value]
/builddir/build/BUILD/shotwell-0.12.3/src/camera/CameraTable.vala:303:5:
warning: statement with no effect [-Wunused-value]
CameraTable.c:3009:15: warning: variable 'tmp166' set but not used
[-Wunused-but-set-variable]
CameraTable.c:2043:7: warning: variable 'usb_cameras_size' set but not
used [-Wunused-but-set-variable]
make: **** [src/camera/CameraTable.o] Error 1
--
You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://redmine.yorba.org/my/account
--
public struct Box {
public static const int HAND_GRENADES = 12;
-- from shotwell/src/Box.vala
Comment 16
Updated by Adam Dingle about 1 year ago
Lucas: just so you know, I just reviewed the patch and discussed it with Clint, so you don't need to look at this at this point.
Comment 17
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:57 UTC ---
This bug was previously known as bug 5553 at http://redmine.yorba.org/show_bug.cgi?id=5553 Imported an attachment (id=262384) Imported an attachment (id=262385)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED