[straighten] rotate_arb() inappropriately crops the image before exporting it.
Submitted by cli..@..ba.org
Assigned to Adam Dingle
Link to original bug (#718414)
Description
---- Reported by clinton@yorba.org 2012-02-15 18:31:00 -0800 ----
Original Redmine bug id: 4753
Original URL: http://redmine.yorba.org/issues/4753
Searchable id: yorba-bug-4753
Original author: Clinton Rogers
Original description:
Steps to reproduce
- Import the attached image into Shotwell and invoke the straighten tool upon it.
- Straighten the image to +15 degrees.
- Invoke the crop tool and carefully observe the preview.
Notice that the pepper in the lower lefthand corner is inappropriately cropped from the full image.
A similar problem occurs with images straightened to negative angles.
At the problem's root seems to be a very subtle bug in the math rotate_arb() is doing to decide how much to translate the image by after rotating it.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Clinton Rogers almost 2 years ago
- File testcase.jpeg added
Comment 2
Updated by Clinton Rogers almost 2 years ago
I trapped the pixbuf exactly as it appears coming out of rotate_arb, before any pipeline steps have been run on it, and the cropping is occurring at this level, rather than elsewhere in the app; this is a clue.
Comment 3
Updated by Adam Dingle almost 2 years ago
- Priority changed from High to Urgent
Comment 4
Updated by Adam Dingle almost 2 years ago
- Status changed from Open to Review
- Assignee set to Adam Dingle
Comment 5
Updated by Adam Dingle almost 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
Fixed in 168ac5c2.
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:56 UTC ---
This bug was previously known as bug 4753 at http://redmine.yorba.org/show_bug.cgi?id=4753 Imported an attachment (id=262346)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.12
Resolution: RESOLVED FIXED