[straighten] Icon required for the straightening tool's toolbar button
Submitted by cli..@..ba.org
Link to original bug (#718146)
Description
---- Reported by clinton@yorba.org 2011-12-06 14:58:00 -0800 ----
Original Redmine bug id: 4474
Original URL: http://redmine.yorba.org/issues/4474
Searchable id: yorba-bug-4474
Original author: Clinton Rogers
Original description:
Before the straightening tool goes live, we'll need an icon to represent it, and there doesn't appear to be an appropriate Gtk.STOCK icon for this. This ticket is to track the state of that task. (This doesn't block the other parts of straighten and can be done last.)
(A proposed design is enclosed; someone would need to vectorize it and make it into an .svg before it was ready for use)
Related issues:
- related to shotwell - Feature #61: straighten photo (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Clinton Rogers almost 2 years ago
- Description updated (diff)
Comment 2
Updated by Clinton Rogers almost 2 years ago
- Priority changed from Low to High
Comment 3
Updated by Freddie Exall almost 2 years ago
- File straighten_icon.svg added
- Estimated time set to 2.00
Here's an attempt. Feel free not to use it if it's not good enough.
Comment 4
Updated by Lucas Beeler almost 2 years ago
I just tried running Shotwell with this icon used for the Straighten tool. It's not a bad icon, but it's so detailed that its detail gets lost at 24px x 24px and it simply looks cluttered and busy. What's more, the green color of the arrow -- the dominant image feature -- doesn't really fit with any of Shotwell's other icons. Among the custom icons we use, both the crop icon and the red-eye icon are predominantly burnt-orange in color. It'd be nice to have the straighten icon match.
Comment 5
Updated by Clinton Rogers almost 2 years ago
- Status changed from Open to Review
Comment 6
Updated by Clinton Rogers almost 2 years ago
- File straighten_icon_attempt_two.svg added
A mixture of Freddie's work (thanks!) and the Shotwell orange-and-grey look.
Comment 7
Updated by Clinton Rogers almost 2 years ago
- Status changed from Review to Open
- % Done changed from 0 to 60
Reason for reopening: more work is planned (remove curled page effect from lower right, reduce detail inside frame)
Comment 8
Updated by Clinton Rogers almost 2 years ago
- File 4474-take-two.diff added
- Status changed from Open to Review
- % Done changed from 60 to 80
Revised version attached and submitted via email.
Comment 9
Updated by Adam Dingle over 1 year ago
- Status changed from Review to Open
-
Assignee deleted (
<strike>
_Clinton Rogers_</strike>
) - Priority changed from High to Urgent
Comment 10
Updated by Clinton Rogers over 1 year ago
Hi Adam,
What else did we want done to this? (I remember there was something
you didn't like about the orange arrow, but that's all I can recall.
When I made it, I eye-droppered the colour from one of the existing
icons, so it should be the same orange, but perceptually, I agree,
it doesn't quite look right.)
I'm sorta kinda back-burnering a lot of other stuff until the Gexiv2
work is done since it involves a golden-path crash, so this may not
get looked at until tomorrow.
Cheers,
-c
On 3/19/12, redmine@redmine.yorba.org redmine@redmine.yorba.org wrote:
Issue #4474 (closed) has been updated by Adam Dingle.
Status changed from Review to Open
Assignee deleted (Clinton Rogers)
Priority changed from High to Urgent
Task #4474 (closed): [straighten] Icon required for the straightening tool's toolbar
button
http://redmine.yorba.org/issues/4474#change-14286
Author: Clinton Rogers
Status: Open
Priority: Urgent
Assignee:
Category: shotwell
Target version: 0.12
Resolution:
Keywords:
Before the straightening tool goes live, we'll need an icon to represent it,
and there doesn't appear to be an appropriate Gtk.STOCK icon for this. This
ticket is to track the state of that task. (This doesn't block the other
parts of straighten and can be done last.)
(A proposed design is enclosed; someone would need to vectorize it and make
it into an .svg before it was ready for use)
--
You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://redmine.yorba.org/my/account
Comment 11
Updated by Adam Dingle over 1 year ago
Clint,
in my last email about this icon I said this:
This looks a bit better, though it still needs work: the orange here is more saturated than in the other icons, and I personally don't like the blackness inside the photo frame: it looks like a terminal window, not a photo.
But I've unassigned you from this ticket since I'd rather have you working on everything else you're assigned to, and since I'm hoping that Daniel Fore may be able to help us out with this.
Comment 12
Updated by Adam Dingle over 1 year ago
- Target version changed from 0.12 to 0.12.1
Comment 13
Updated by Adam Dingle over 1 year ago
- Target version changed from 0.12.1 to 0.12.2
Comment 14
Updated by Adam Dingle over 1 year ago
- Priority changed from Urgent to High
Comment 15
Updated by Adam Dingle over 1 year ago
- Target version changed from 0.12.2 to 0.13
Comment 16
Updated by Alexander Wilms over 1 year ago
- File straighten.svg added
Hi, I used Daniel Foré's icons as basis for this one. I hope its alright
Comment 17
Updated by Adam Dingle over 1 year ago
- Status changed from Open to Review
Comment 18
Updated by Lucas Beeler over 1 year ago
- Status changed from Review to Open
@Alexander:
Thank you so much for contributing a simplified icon for the Straighten tool! A few improvements I think we'll need to see before landing this icon:
(i)
The orange gradient used in the overlaid arrow should use a more vivid, saturated tint of orange. Ideally, it would use similar (if not the same) gradient start and end colors as those used in the "Red-eye" icon to enhance visual consistency.
(ii)
The iconographic photo uses a deep cyan background color. The problem is that nothing else in the toolbar is deep cyan. The "Adjust" tool icon, however, has a medium aquamarine color in its center slider that is very similar to your deep cyan. Could you replace your deep cyan background with the same medium aquamarine color used in the "Adjust" tool icon? How saturated you want the medium aquamarine to be is up to you.
Comment 19
Updated by Alexander Wilms over 1 year ago
- File straighten_2.svg added
Hi Lucas,
I did the suggested changes. Is licensing an issue, since the original icons weren't mine? I'd assume that such a single icon would be trivial.
Comment 20
Updated by Adam Dingle over 1 year ago
- Status changed from Open to Review
Comment 21
Updated by Lucas Beeler over 1 year ago
- Status changed from Review to Open
Hi Alexander:
The new version of the icon looks great! As regards licensing, what license was the original version of the icon distributed under?
Lucas
Comment 22
Updated by Alexander Wilms over 1 year ago
Thanks! It's the GNU GPL v3: https://launchpad.net/elementaryicons
Comment 23
Updated by Lucas Beeler about 1 year ago
- Status changed from Open to 5
- Resolution set to fixed
Daniel Foré has agreed to dual-license (under the LGPL) the icon from which Alexander derived his Straighten Tool icon here attached. This icon was incorporated into Shotwell in 06b0775d. Alexander Wilms is credited in the THANKS file and the derived icon is copyright Yorba Foundation 2012.
Comment 24
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:55 UTC ---
This bug was previously known as bug 4474 at http://redmine.yorba.org/show_bug.cgi?id=4474 Imported an attachment (id=262218) Imported an attachment (id=262219) Imported an attachment (id=262220) Imported an attachment (id=262221) Imported an attachment (id=262222) Imported an attachment (id=262223)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED