Compile fails if faces are enabled
Submitted by an unknown user
Link to original bug (#718124)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-12-19 16:32:00 -0800 ----
Original Redmine bug id: 4518
Original URL: http://redmine.yorba.org/issues/4518
Searchable id: yorba-bug-4518
Original author: Frederik Sdun
Original description:
If I configure shotwell with the following options the build fails with the attached output:
command:
./configure --prefix=/usr --debug --enable-build-for-glade --install-headers --unity-support --define=ENABLE_FACES
output:
Compiling Vala code...
src/faces/FaceShape.vala:18.15-18.23: error: The symbol `FacesTool' could not be found
protected FacesTool.EditingFaceToolWindow face_window;
^^^^^^^
src/faces/FaceShape.vala:20.15-20.25: error: The type name `PhotoCanvas' could not be found
protected PhotoCanvas canvas;
^^^^^^^^^
src/faces/FaceShape.vala:26.18-26.26: error: The symbol `FacesTool' could not be found
private weak FacesTool.FaceWidget face_widget = null;
^^^^^^^
src/faces/FaceShape.vala:28.22-28.32: error: The type name `PhotoCanvas' could not be found
public FaceShape(PhotoCanvas canvas) {
^^^^^^^^^
src/faces/FaceShape.vala:55.45-55.55: error: The type name `PhotoCanvas' could not be found
public static FaceShape from_serialized(PhotoCanvas canvas, string serialized)
^^^^^^^^^
src/faces/FaceShape.vala:56.12-56.25: error: The type name `FaceShapeError' could not be found
throws FaceShapeError {
^^^^^^^^^^^^
src/faces/FaceShape.vala:84.28-84.36: error: The symbol `FacesTool' could not be found
public void set_widget(FacesTool.FaceWidget face_widget) {
^^^^^^^
src/faces/FaceShape.vala:88.12-88.20: error: The symbol `FacesTool' could not be found
public FacesTool.FaceWidget get_widget() {
^^^^^^^
src/faces/FaceShape.vala:180.26-180.36: error: The type name `PhotoCanvas' could not be found
public FaceRectangle(PhotoCanvas canvas, int x, int y,
^^^^^^^^^
src/faces/FaceShape.vala:210.53-210.63: error: The type name `PhotoCanvas' could not be found
public static new FaceRectangle from_serialized(PhotoCanvas canvas, string[] args)
^^^^^^^^^
src/faces/FaceShape.vala:211.16-211.29: error: The type name `FaceShapeError' could not be found
throws FaceShapeError {
^^^^^^^^^^^^
Compilation failed: 11 error(s), 0 warning(s)
make: *** [src/.stamp] Fehler 1
The commit 2373966a918a1df048f0956937d5807a7b1e88b4 on git://github.com/playya/shotwell.git fixes this issue
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:47:00 -0700 ----
History
Comment 1
Updated by Adam Dingle almost 2 years ago
- Status changed from Open to Review
- Target version set to 0.12
Thanks for the fix! Lucas, please review.
Comment 2
Updated by Adam Dingle almost 2 years ago
-
Target version deleted (
_0.12_)
Comment 3
Updated by Jim Nelson 11 months ago
- Target version set to 0.14.0
Comment 4
Updated by Jim Nelson 11 months ago
- Category set to build
Comment 5
Updated by Lucas Beeler 11 months ago
- Status changed from Review to 5
- Assignee set to Frederik Sdun
- Resolution set to worksforme
@Frederik:
Thanks for the patch, but thankfully, it's not necessary any more. Shotwell with Faces tool support now lives in its own branch in our git repository. After cloning the Shotwell repo, you should only need to type
$ git checkout faces
to set up your local repo to track the Shotwell faces branch. This branch isn't completely sync'd with the latest Shotwell master, so if you're still interested in contributing to the Shotwell Faces tool, you could do that!
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Invalid
--- Bug imported by chaz@yorba.org 2013-11-25 21:55 UTC ---
This bug was previously known as bug 4518 at http://redmine.yorba.org/show_bug.cgi?id=4518
Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.14.0
Resolution: RESOLVED INVALID