single shared menu for all Shotwell views
Submitted by Adam Dingle
Assigned to Adam Dingle
Link to original bug (#718099)
Description
---- Reported by adam@yorba.org 2012-01-04 17:19:00 -0800 ----
Original Redmine bug id: 4562
Original URL: http://redmine.yorba.org/issues/4562
Searchable id: yorba-bug-4562
Original author: Adam Dingle
Original description:
I'm becoming convinced that we may have to refactor our code to use a single menu for all views in Shotwell, dynamically enabling and disabling (or adding and removing) menu items in a context-dependent way. Today, we replace the entire menu on the fly and this has proven fragile in Unity, yielding bugs that seem to be fixed but keep coming back.
Implementing this would be non-trivial, but would almost certainly fix #2592 (closed) and #4303 for good, and would make #4377 (closed) unnecessary.
Related issues:
- related to shotwell - 2592: [gtk3, ubuntu] Shotwell menu flashes when user switches p... (Fixed)
- related to shotwell - 4303: [gtk3] sidebar flashes each time I select a new item (Fixed)
- related to shotwell - 4377: Determine a more robust and elegant way to check if appme... (Invalid)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Adam Dingle almost 2 years ago
- Assignee set to Adam Dingle
This would not be a small change. I'm going to take a closer look at what's involved.
Comment 2
Updated by Adam Dingle almost 2 years ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
Too late for 0.12.
Comment 3
Updated by Adam Dingle almost 2 years ago
- Target version set to 0.12
Still considering for 0.12, actually.
Comment 4
Updated by Adam Dingle over 1 year ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
I made a bunch of progress on this, but it's probably too late to make 0.12 at this point.
Comment 5
Updated by Lucas Beeler over 1 year ago
Even if it can't make 0.12, thanks for the heroic effort, my friend. All of us on the Shotwell team appreciate it.
Comment 6
Updated by Adam Dingle over 1 year ago
- Target version set to 0.12
It may yet happen.
Comment 7
Updated by Adam Dingle over 1 year ago
- Status changed from Open to Review
Comment 8
Updated by Adam Dingle over 1 year ago
- Status changed from Review to 5
- Resolution set to fixed
Comment 9
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:55 UTC ---
This bug was previously known as bug 4562 at http://redmine.yorba.org/show_bug.cgi?id=4562
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.12
Resolution: RESOLVED FIXED