Events don't get sorted in Sidebar
Submitted by an unknown user
Link to original bug (#718067)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-08-12 12:55:00 -0700 ----
Original Redmine bug id: 3979
Original URL: http://redmine.yorba.org/issues/3979
Searchable id: yorba-bug-3979
Original author: Valent ín Barros
Original description:
I can see the View -> Sort Events option in import_queue, photo, import, trash, media, offline and events_directory ui files, but currently it doesn't have so much sense, because the only thing it does is to sort the thumbnails in EventsDirectoryPage --so it should only be in events_directory.ui.
Unless it is intended to also sort the order of the Sidebar events entry. And I think that here is the bug, because in the EventsDirectoryPage there is some code that appears to do so, but it doesn't --you can change events order and if you close and reopen Shotwell again you'll see the entries in the events sidebar sorted, but they don't be resorted at the time you change that option. I think that this is because ConfigurationFacade.events_sort_ascending_changed is never thrown, but I don't know why because I don't know so much about GConf/DConf... :S
What do you think about this? I hope I've explained well.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Priority changed from Normal to High
- Target version set to 0.11
I just tried this and you're right: when the user changes the event sort order, the change doesn't take effect in the sidebar until you restart Shotwell. We should fix this for 0.11.
Comment 2
Updated by Valentín Barros over 2 years ago
- File 0008-Fix-to-3979.patch added
- Priority changed from High to Normal
-
Target version deleted (
<strike>
_0.11_</strike>
)
The problem is caused by HybridEngine, since it is a wrapper to GConfConfigurationEngine and GSettingsConfigurationEngine; it implements ConfigurationEngine and thus, it has property_changed signal. But it doesn't rethrow the signals thrown by the two classes it wraps.
Attached a simple patch to fix this.
Comment 3
Updated by Valentín Barros over 2 years ago
- Priority changed from Normal to High
- Target version set to 0.11
(Restoring the metadata again... I simply don't know why Redmine does this :S )
Comment 4
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
Comment 5
Updated by Lucas Beeler over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
Fixed in 36431384. Thanks Valentin!
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:55 UTC ---
This bug was previously known as bug 3979 at http://redmine.yorba.org/show_bug.cgi?id=3979 Imported an attachment (id=262182)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.11
Resolution: RESOLVED FIXED