The application fails to compile with a missing header.
Submitted by cli..@..ba.org
Assigned to Lucas Beeler
Link to original bug (#718061)
Description
---- Reported by clinton@yorba.org 2011-08-15 13:16:00 -0700 ----
Original Redmine bug id: 3985
Original URL: http://redmine.yorba.org/issues/3985
Searchable id: yorba-bug-3985
Original author: Clinton Rogers
Original description:
Shotwell fails to compile out of 'master', with the C compiler complaining that it can't find 'glib.h', even when libglib2.0-dev is installed.
Steps to reproduce:
With a fresh Ubuntu 11.04 install, grab the dependencies as specified at http ://yorba.org/shotwell/install<source.
Git clone the source tree as specified at http://yorba.org/shotwell/install<s ource.
In the directory the source was checked out to in step two, run './configure'
In the directory the source was checked out to in step two, un 'make' and observe the results.
Notice that the makefile fails to complete, with compilation of a generated .c file erroring out on the missing header.
Note: this can be worked around by manually adding symlinks for glib.h, glibconfig.h et al in /usr/include.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:46:00 -0700 ----
History
Comment 1
Updated by Clinton Rogers over 2 years ago
It looks like the contents of EXT_PKGS may not be getting passed along to the C compiler.
Comment 2
Updated by Clinton Rogers over 2 years ago
- File 3985.diff added
Comment 3
Updated by Clinton Rogers over 2 years ago
- Category set to 4
- Assignee set to Lucas Beeler
- Target version set to 0.11
Up for review.
Comment 4
Updated by Adam Dingle over 2 years ago
I can't reproduce this on my Oneiric machine. You said that the compilation of 'a generated C file' produces a build error. Which generated C file is that? Can you post the complete command line which 'make' prints when it attempts to compile that file (without your patch)? I'd be curious to compare that with the 'make' output on my own machine.
Comment 5
Updated by Clinton Rogers over 2 years ago
From an unmodified version of trunk, on a pristine Natty install:
Resources.c:10:18: fatal error: glib.h: No such file or directory
compilation terminated.
shotwell-publishing-extras.c:10:18: fatal error: glib.h: No such file or directory
compilation terminated.
YandexPublishing.c:10:18: fatal error: glib.h: No such file or directory
compilation terminated.
PiwigoPublishing.c:10:18: fatal error: glib.h: No such file or directory
compilation terminated.
RESTSupport.c:10:18: fatal error: glib.h: No such file or directory
compilation terminated.
string.c:10:18: fatal error: glib.h: No such file or directory
compilation terminated.
make2: *** [Resources.o] Error 1
make2: Leaving directory `/home/clinton/work/cleanroom/unfixed/shotwell/plugins/shotwell-publishing- extras'
make1: *** [shotwell-publishing-extras] Error 2
make1: Leaving directory `/home/clinton/work/cleanroom/unfixed/shotwell/plugins'
make: *** [plugins] Error 2
This is immediately after installing all dependencies, opening a new terminal so any env var changes will take effect, checking out and running ./configure with no options.
Comment 6
Updated by Adam Dingle over 2 years ago
OK, thanks for this additional information. What I'd also like to see is the command line which 'make' prints on your machine as it tries to build Resources.c (the first file which fails in the output you provided). For example, on my machine it prints this:
cc -c pkg-config --print-errors --cflags gobject-2.0 glib-2.0 gdk-2.0 gtk+-2.0
-nostdlib -export-dynamic -O2 -g -pipe -fPIC
-D_VERSION='"0.10.90+trunk"' -DGETTEXT_PACKAGE='"shotwell"' -I../..
Resources.c shotwell-transitions.c FadeEffect.c SlideEffect.c CrumbleEffect.c
Do you see the same?
Comment 7
Updated by Clinton Rogers over 2 years ago
From my machine, at the same point in the makefile as your message:
make2: Entering directory `/home/clinton/work/cleanroom/unfixed/shotwell/plugins/shotwell-publishing- extras'
cc -c pkg-config --print-errors --cflags gobject-2.0 glib-2.0 gdk-2.0 gtk+-2.0 gtk+-2.0 libsoup-2.4 libxml-2.0 webkit-1.0 json-glib-1.0 gee-1.0
-nostdlib -export-dynamic -O2 -g -pipe -fPIC -D_VERSION='"0.10.90+trunk"'
-DGETTEXT_PACKAGE='"shotwell"' -I../.. Resources.c shotwell-publishing-
extras.c YandexPublishing.c PiwigoPublishing.c RESTSupport.c string.c
Comment 8
Updated by Jonas Bushart over 2 years ago
This is related to #3982 (closed) remove json-glib dependency.
Hir is the message from the mailinglist:
bq.
Hi all,
I just found out that the instructions to build from source found
here: http://yorba.org/shotwell/install<source are missing one
dependency on Ubuntu: libjson-glib-dev. So if you're trying to build
from source and get an error message when building the publishing
plugins that it cannot find glib.h, add the missing dependency.
Cheers,
Bruno
Thats the only problem that exists.
Comment 9
Updated by Adam Dingle over 2 years ago
- Status changed from Open to 5
- Resolution set to duplicate
Aha - thanks for that insight, Jonas. So this is essentially a duplicate of #3982 (closed).
Comment 10
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Duplicate
--- Bug imported by chaz@yorba.org 2013-11-25 21:55 UTC ---
This bug was previously known as bug 3985 at http://redmine.yorba.org/show_bug.cgi?id=3985 Imported an attachment (id=262175)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.11
Resolution: RESOLVED DUPLICATE