Add Unity launcher progress bar (more)
Submitted by an unknown user
Link to original bug (#718045)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-08-18 14:39:00 -0700 ----
Original Redmine bug id: 4001
Original URL: http://redmine.yorba.org/issues/4001
Searchable id: yorba-bug-4001
Original author: Jonas Bushart
Original description:
Feature description like #3992 but for more pages.
Patch includes:
Adds UnityProgressBar.vala to have control which progress bar is shown on the launcher, because Shotwell kann have multiple progress bars and Unity only one. Selection is my by time (the first one gets it) on by importance (more important and you get it).
Adding more progress bars is simple. Create an UnityProgressBar instance, use set_visible(true) and set_progress(fraction). If visible is true it will try each time you use set_progress to get the Unity progress bar. To remove the progress bar from the launcher use set_visible(false) or reset().
Related issues:
- related to shotwell - Feature #3992: Add Unity launcher progress bar (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----
History
Comment 1
Updated by Jonas Bushart over 2 years ago
The patch is against master. So ist not for installing after the #3992 patch. But you could strip this to LibraryWindow.vala only if you remove the part of the other *.vala files exept UnityProgressBar.vala.
Comment 2
Updated by Jim Nelson over 2 years ago
Jonas, I see that this is an expansion of the work you've done in #3992, but I'm not sure it's clear why this merits a different ticket. Should we close this ticket and move the patch to #3992, and let the work develops there?
What I do think is that if we're going to add Unity support it should be like you've done it here, where the configure script specifies --unity-support generically rather than --unity-progress-bars, as other Unity-specific work may follow.
That said, I loathe adding more #ifdefs to Shotwell for platform-specific code. The Shotwell team should discuss this further when we're all gathered.
Comment 3
Updated by Jonas Bushart over 2 years ago
- File 0001-add-Unity-progress-bar-for-Shotwell_s-progress-bars..patch added
You can move this patch around if you like. But I found a little problem. UnityProgressBar.vala should only be added if you want Unity support. I add the newer patch. Now it is tested with and without Unity support.
I opened another ticket due to Erik wrote
bq.
I'd say that's too much for this ticket;
Comment 4
Updated by Jonas Bushart over 2 years ago
-
File deleted (
<strike>
_0001-add-Unity-progress-bar-for-Shotwell_s-progress-bars..patch_</strike>
)
Comment 5
Updated by Jonas Bushart about 2 years ago
Whats with this path. Do you want/need it. Or is 3992 enough for you?
If you want to use this patch I think you have to remove the 3992 patch (not tested) because they work very differently.
Comment 6
Updated by Lucas Beeler about 2 years ago
Hi Jonas,
We're in the middle of getting Shotwell 0.11.0 out the door right now, but as soon as we do, I'll take a look at your patch and discuss it with the other members of the Shotwell team. We haven't really developed a plan for Unity integration one way or another as yet. And thank you so much for your patch!
Lucas
Comment 7
Updated by Jonas Bushart about 2 years ago
I know you are a bit busy with 0.11, this should only be a remarker and nothing like "hurry up".
Comment 8
Updated by Adam Dingle about 2 years ago
- Description updated (diff)
- Status changed from Open to Review
- Priority changed from Normal to High
- Target version set to 0.12
Let's review this and commit if appropriate for 0.12.
Comment 9
Updated by Lucas Beeler about 2 years ago
@ Jonas
Hi. I just tried to review your patch, but with all the activity in Shotwell master since August, it can no longer be applied. Could you send me an updated patch diff'd against the current Shotwell master? Once you do, I'll review this and hopefully we can get it landed in a day or two!
Lucas
Comment 10
Updated by Jonas Bushart about 2 years ago
- File 0001-Revert-Adds-the-ability-for-Shotwell-to-interoperate.patch added
- File 0002-add-Unity-progress-bar-for-Shotwell-s-progress-bars.patch added
- Assignee changed from Jonas Bushart to Jim Nelson
- Priority changed from High to Normal
-
Target version deleted (
<strike>
_0.12_</strike>
)
Both patches has to be used. The first one simple reverts 3992.
Compiles with current Ubuntu. 'libunity-dev' is required.
Comment 11
Updated by Adam Dingle about 2 years ago
- Assignee changed from Jim Nelson to Jonas Bushart
- Priority changed from Normal to High
- Target version set to 0.12
Thanks for the updated patch. On this ticket, "Target version" should be 0.12 since we're considering this for inclusion in 0.12. For the same reason, Priority should be High. The assignee should still be you since you're working on this (even though it's now our turn to review, as indicated by the Review status).
Comment 12
Updated by Jonas Bushart about 2 years ago
Oh, sorry. I haven't noticed I changed those settings.
Comment 13
Updated by Lucas Beeler about 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
Closed in 6199368a. Thanks Jonas!
Comment 14
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:55 UTC ---
This bug was previously known as bug 4001 at http://redmine.yorba.org/show_bug.cgi?id=4001 Imported an attachment (id=262167) Imported an attachment (id=262168) Imported an attachment (id=262169)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.12
Resolution: RESOLVED FIXED