searches with "does not contain" do not work
Submitted by an unknown user
Assigned to cli..@..ba.org
Link to original bug (#717871)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-05-25 18:31:00 -0700 ----
Original Redmine bug id: 3659
Original URL: http://redmine.yorba.org/issues/3659
Searchable id: yorba-bug-3659
Original author: Norbert Preining
Original description:
Hi all,
I want to search for all photos not containing a specific tag @foo. But when I create a search with
Tag does not contain @foo
still all the photos tagged with @foo are included.
Could it be that the “does not contain†code path does the same as the “does contain†code path, which would be wrong, IMHO.
Thanks,
Norbert
Related issues:
- duplicated by shotwell - 4530: Performing a search that includes one tag and not another... (Duplicate)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
Norbert,
the search you described will return all photos which have any tag that does not contain “fooâ€. So if a photo has tags “foo†and “barâ€, then your search will return that photo since “bar†does not contain “fooâ€.
Instead, you should create a search that uses the match type “noneâ€, and has a rule “tag contains 'foo'â€. That will do what you want.
I agree that this is potentially confusing, so I'll leave this bug open for the moment and we'll discuss this more on the Shotwell team.
Comment 2
Updated by Adam Dingle over 2 years ago
- Priority set to High
Comment 3
Updated by Norbert Preining over 2 years ago
Hi Adam,
yeah, that is what I surmissed that all tags are tested one by one. Thanks for the suggestion with using none.
But I think the iintuitive and more useful semantics is that a negative search criteria changes the polarization of subterms, i.e., if Tag does not contain something, then NO tag should contain it. That comes from the inversion of eistential to universal quantifier.
Thanks for consideration
Norbert
Comment 4
Updated by Adam Dingle almost 2 years ago
- Description updated (diff)
- Target version set to 0.12
This has confused a couple of users at least. Worth considering changing for 0.12.
Comment 5
Updated by Adam Dingle almost 2 years ago
- Subject changed from searches with "does not contain" does not work to searches with "does not contain" do not work
Comment 6
Updated by Adam Dingle over 1 year ago
- Assignee set to Clinton Rogers
Comment 7
Updated by Clinton Rogers over 1 year ago
- File 3659.diff added
- Status changed from Open to Review
- % Done changed from 0 to 70
Comment 8
Updated by Clinton Rogers over 1 year ago
- Status changed from Review to 5
- % Done changed from 70 to 100
- Resolution set to fixed
Comment 9
Updated by Adam Dingle over 1 year ago
Awesome. Nice to see that fixing this wasn't too gnarly.
Comment 10
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:54 UTC ---
This bug was previously known as bug 3659 at http://redmine.yorba.org/show_bug.cgi?id=3659 Imported an attachment (id=262123)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.12
Resolution: RESOLVED FIXED