"Hide photos already imported" in camera view is not working correctly
Submitted by an unknown user
Link to original bug (#717735)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-07-29 14:34:00 -0700 ----
Original Redmine bug id: 3895
Original URL: http://redmine.yorba.org/issues/3895
Searchable id: yorba-bug-3895
Original author: Jonas Bushart
Original description:
I was testing with the "Hide photos already imported" feature so I used some files out of my libary and checked them. Theyare in the libary but in the camera view they are allways show even if "Hide photos already imported" is selected.
I took this 49 images and imported them into a new libary. Only two images get hidden if I select the option. All others will be shown.
If I import them all images are correctly recogniced as imported.
I imported all images and then I tried to import them a second time. I added the screenshot of the import dialog. Images DSCF0053.JPG and DSCF0055.JPG are the correct working images. Only those two images get hidden in the camera view by selecting the "Hide photos already imported" feature. The following paths are incorrect. But there are images with the path /home/jonas/Bilder/2010/05/04/DSCF0017.JPG and /home/jonas/Bilder/2010/05/04/DSCF0018.JPG. But those two and the other 45 images are still show if the "Hide photos already imported" feature is selected.
I can upload the images if you want to test with them but they have a size of 84MB.
Related issues:
- duplicated by shotwell - 7684: hide photos already imported (Duplicate)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-16 14:44:00 -0700 ----
History
Comment 1
Updated by Eric Gregory over 2 years ago
We've fixed various problems with this feature recently. What version of Shotwell are you running? If it's not 0.10.1, could you update and try it again?
Comment 2
Updated by Jonas Bushart over 2 years ago
This bug is in 10.1 but the test system described above is the development version.
Comment 3
Updated by Adam Dingle almost 2 years ago
- Description updated (diff)
- Priority changed from Normal to High
- Target version set to 0.12
This has apparently also been reported downstream at
https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/907937
Worth investigating for 0.12.
Comment 4
Updated by Peter Seiderer almost 2 years ago
- File patch-fix-hide-fotos-already-imported.patch added
Same problem for me with Shotwell 0.11.5 on OpenSuse-12.1 and import from Canon EOS 600D (direkt usb link or card reader).
Tracked down the problem to ImportPage.load_previews_and_metadata() using GPhoto.load_preview() for the thumbnail and associated preview_md5 value.
All other e.g. BatchImport use metadata.flatten_exif_preview() to get the thumbnail data for which the thumbnail_md5 is calculated and which is stored to the shotwell data base.
In GPhoto.load_preview() there is code to strip some trailing bytes from the thumbnail data (added as fix for 2905, see git commit 6e986458), this results in different md5 sums used in ImportPage and in the shotwell data base.
Working fix for me was to revert git commit 6e986458, see attached patch.
Comment 5
Updated by Adam Dingle almost 2 years ago
- Status changed from Open to Review
Peter, thanks for investigating and for the patch. Lucas, please review.
Comment 6
Updated by Lucas Beeler almost 2 years ago
- Status changed from Review to Open
Hi Jonas and Peter,
We can't take this patch as-is. While it may solve the duplicate detection problem in your particular case, it also breaks it in other cases. To fix this bug comprehensively, we'd like to get more information about what's actually going on here. Could you email to shotwell@yorba.org the following: (i) a copy of at least one photo file that exhibits the problem; (ii) a copy of a test shotwell.db file that includes an md5 sum for the photo you sent.
Cheers,
Lucas
Comment 7
Updated by Jonas Bushart almost 2 years ago
I just send you a mail with 10 problematic images. I hope you can recieve the email because it has a 22mb attachment.
EDIT:
I have send you a email with downloadlinks, because the attachment hasn't worked.
Comment 8
Updated by Peter Seiderer almost 2 years ago
Hello Lucas,
you can download 7 example photos and the shotwell photo.db file
from http://h65951.serverkompetenz.net/PeterSeiderer/100CANON/index.html
Peter
Comment 9
Updated by Adam Dingle over 1 year ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
Comment 10
Updated by Jim Nelson 11 months ago
- Target version set to 0.14.0
Comment 11
Updated by Jim Nelson 11 months ago
- Category set to camera
Comment 12
Updated by Jim Nelson 9 months ago
- Target version changed from 0.14.0 to 0.15.0
Comment 13
Updated by Jim Nelson 8 months ago
- Target version changed from 0.15.0 to 0.16.0
Comment 14
Updated by Jim Nelson 6 months ago
-
Target version deleted (
<strike>
_0.16.0_</strike>
)
--- Bug imported by chaz@yorba.org 2013-11-25 21:53 UTC ---
This bug was previously known as bug 3895 at http://redmine.yorba.org/show_bug.cgi?id=3895 Imported an attachment (id=262076) Imported an attachment (id=262077)
Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Resolution: RESOLVED FIXED