[faces] autocomplete for faces tool
Submitted by an unknown user
Link to original bug (#717733)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-07-30 02:50:00 -0700 ----
Original Redmine bug id: 3897
Original URL: http://redmine.yorba.org/issues/3897
Searchable id: yorba-bug-3897
Original author: Wolfgang Steitz
Original description:
when entering names using the faces tool, shotwell should autocomplete the names.
Related issues:
- duplicated by shotwell - Feature #4032 (closed): Faces should have auto-complete (Duplicate)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-02-07 11:21:00 -0800 ----
History
Comment 1
Updated by Jim Nelson about 2 years ago
- Description updated (diff)
- Category set to 4
- Priority changed from Normal to High
- Target version set to 0.12
If we get Faces work completed, we should fix this as well.
Comment 2
Updated by Valentín Barros about 2 years ago
Hi!
Due to work/studies I have no time to keep actively contributing, but I have two work-in-progress patches (one for this bug and the other for #1702 (closed)) that I will update and share them with you tomorrow or this Monday, maybe you could use them.
Comment 3
Updated by Adam Dingle about 2 years ago
- Subject changed from autocomplete for faces tool to [faces] autocomplete for faces tool
Comment 4
Updated by Frederik Sdun almost 2 years ago
- Due date set to 12/01/2011
- Priority changed from High to Normal
- % Done changed from 0 to 50
- Estimated time set to 1.00
- Resolution set to fixed
I implemented a basic name completion and fixed some faces related bugs on https://github.com/playya/shotwell
It's not perfect, but it works :)
please review. The branch is rebased to 9c05dc3eda9cdd47ff977e1999980e9388a7fa59
Comment 5
Updated by Adam Dingle almost 2 years ago
- Status changed from Open to Review
- Priority changed from Normal to High
-
Resolution deleted (
<strike>
_fixed_</strike>
)
Thanks for the code update. Lucas, please review.
(At Yorba we don't change a ticket's resolution to 'fixed' until it's committed to git master, so I've reset the resolution for now).
Comment 6
Updated by Frederik Sdun almost 2 years ago
- Assignee set to Lucas Beeler
assigned to Lucas that he get'S a notification to review my code
Comment 7
Updated by Adam Dingle almost 2 years ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
Comment 8
Updated by Lucas Beeler 10 months ago
- Status changed from Review to Open
-
Assignee deleted (
<strike>
_Lucas Beeler_</strike>
)
The repo linked to in this ticket is diff'd against the summer 2011 version of the Faces tool. We were lucky to enough to have Valentín as a GSoC student for two summers -- 2011 and 2012. The summer 2012 version of the Faces tool differs substantially from the 2011 version. The linked patch is no longer applicable but it might be a useful starting point for someone interested in implementing this feature against the 2012 version. To get the 2012 version, just clone the Shotwell git repo and checkout the "faces" branch.
Comment 9
Updated by Jim Nelson 10 months ago
- Category set to faces
Comment 10
Updated by Valentín Barros 10 months ago
- File 0001-Implemented-name-autocompletion-for-faces-tool-featu.patch added
Hi!
I've just adapted an old patch that implements this —I've just adapted it to make it compatible with the current status of faces branch.
Cheers!
Comment 11
Updated by Lucas Beeler 10 months ago
- Status changed from Open to Review
--- Bug imported by chaz@yorba.org 2013-11-25 21:53 UTC ---
This bug was previously known as bug 3897 at http://redmine.yorba.org/show_bug.cgi?id=3897 Imported an attachment (id=262073)
Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution