crash after setting rating to 0
Submitted by Adam Dingle
Assigned to Eric Gregory
Link to original bug (#717575)
Description
---- Reported by adam@yorba.org 2011-04-25 08:24:00 -0700 ----
Original Redmine bug id: 3541
Original URL: http://redmine.yorba.org/issues/3541
Searchable id: yorba-bug-3541
Original author: Adam Dingle
Original description:
Bruno Vellutini reported this on the mailing list:
I just updated to 0.9.3 and noticed a reproducible crash behavior. These are
the steps:
Import files to library without copying them.
Make sure the rating filter is “All photos†(CTRL+0).
Double click a photo and start to navigate with arrows.
Press 9 to reject a photo.
Go to next photo and return to the rejected photo.
Press 0 to unmark the rejection.
Press arrow key to go to the next photo <- CRASH
Stacktrace raises:
ERROR:src/MediaViewTracker.c:464:media_accumulator_real_uninclude: assertion
failed: (self->total > 0)
Program received signal SIGABRT, Aborted.
0x0012e416 in __kernel_vsyscall ()
Note: Shotwell crashes only if the rating filter is “All photosâ€. When “All
photos + rejected†is set, it does not crash.
Related issues:
- related to shotwell - 6481: Segfault (on importing while flagged is toggled in the se... (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Eric Gregory
Comment 2
Updated by Adam Dingle over 2 years ago
- Target version changed from 0.10 to 9
Marking for 0.9.4, though we haven't decided whether there will be such a release.
Comment 3
Updated by Eric Gregory over 2 years ago
The deal with this bug is that the single photo view always selects the photo you're currently viewing (EditingHostPage's ViewCollection). But it also selects the photo on the previous page, i.e. the page from where you entered single photo mode.
The problem with this approach is that if the user makes changes to the photo that causes it to be removed from the previous page, the select/unselect operations will be selecting or unselecting photos that are no longer present on that page.
Comment 4
Updated by Eric Gregory over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Fixed in faab91e5
Comment 5
Updated by Adam Dingle over 2 years ago
- Target version changed from 9 to 0.10
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:52 UTC ---
This bug was previously known as bug 3541 at http://redmine.yorba.org/show_bug.cgi?id=3541
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED