Shotwell saves edited png with jpg extension
Submitted by Adam Dingle
Assigned to cli..@..ba.org
Link to original bug (#717569)
Description
---- Reported by adam@yorba.org 2011-04-25 13:09:00 -0700 ----
Original Redmine bug id: 3547
Original URL: http://redmine.yorba.org/issues/3547
Searchable id: yorba-bug-3547
Original author: Adam Dingle
Original description:
Reported at https://bugs.launchpad.net/bugs/770459 :
Open a png file with Shotwell.
Edit (for instance Flip Horizontally).
Save and close.
The file now has a jpg extension, although it's still a png file.
Eye of gnome throws an error when trying to open it. When changing the extension back to png the file can be opened again.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Clinton Rogers
Comment 2
Updated by Clinton Rogers over 2 years ago
Unable to reproduce; will contact the original reporter via Launchpad for more info as needed.
Comment 3
Updated by Adam Dingle over 2 years ago
I can reproduce this easily in the current trunk. To see this, you'll need to apply Eric's pending fix for#3591sincedirect-edit mode is broken at the moment. Clinton, I'll forward to that fix to you by email.
With that fix in place, open a PNG file in direct edit mode, flip it horizontally and save. As the original reporter observed, the file will be saved with extension “.jpg†but will still be a PNG file. Instead, we should save using the original .png extension.
Comment 4
Updated by Clinton Rogers over 2 years ago
Reproduced; investigating.
Comment 5
Updated by Clinton Rogers over 2 years ago
This appears to be a bug in how Shotwell handles saving when the only operation is a flip or rotate, but the actual pixel values weren't modified; if I perform a color-modifying operation, then do the rest of the steps, it works as intended…
Comment 6
Updated by Clinton Rogers over 2 years ago
Proposed fix submitted via email; basically, we were trying to avoid decoding and rewriting a non-lossy image as if it were a lossy one.
Comment 7
Updated by Clinton Rogers over 2 years ago
- Resolution set to fixed
- % Done changed from 0 to 100
Comment 8
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:52 UTC ---
This bug was previously known as bug 3547 at http://redmine.yorba.org/show_bug.cgi?id=3547
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED