Extended Information has no close box on Fedora 15
Submitted by Adam Dingle
Assigned to cli..@..ba.org
Link to original bug (#717547)
Description
---- Reported by adam@yorba.org 2011-05-02 12:14:00 -0700 ----
Original Redmine bug id: 3571
Original URL: http://redmine.yorba.org/issues/3571
Searchable id: yorba-bug-3571
Original author: Adam Dingle
Original description:
On Fedora 15, the Extended Information window has no close box. It should have one.
(As a workaround, it's possible to close this window by pressing Escape or using the View menu checkbox.)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
Actually, it appears that non-modal dialogs in general don't have close boxes on Fedora 15, so we don't want to force one to appear. What we do need is a Close button at the buttom of the dialog, which other dialogs do have.
Comment 2
Updated by Adam Dingle over 2 years ago
- Assignee changed from Anonymous to Clinton Rogers
Clinton, Lucas will give you a way to log in on his machine so you can work on this.
Comment 3
Updated by Clinton Rogers over 2 years ago
Propose wrapping the alignment that's there in a VBox, then adding a second alignment containing a single button beneath that. Will use GTK_STOCK_CLOSE to avoid adding a translation string.
Comment 4
Updated by Adam Dingle over 2 years ago
I think there may be an easier way. Have a look at gtk_dialog_new_with_buttons – could you just use that?
Comment 5
Updated by Clinton Rogers over 2 years ago
Submitted a patch via email that:
Changes ExtendedPropertiesWindow so it inherits from Dialog instead of Window
Adds a button with Stock.%(=caps)CLOSE% in the label
Adds a signal for 'clicked' on this button
connects the signal in ExtendedPropertiesWindow's ctor and disconnects it in the dtor
The signal handler:
calls ExtendedPropertiesWindow.hide()
As it turns out, this affects some XFCE themes too, most notably 'B5', 'Tux' and 'Beastie', since these jack the close button as well.
Comment 6
Updated by Clinton Rogers over 2 years ago
- Resolution set to fixed
- % Done changed from 0 to 100
We got this all, ah, buttoned down in b13e3f1b
Comment 7
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:52 UTC ---
This bug was previously known as bug 3571 at http://redmine.yorba.org/show_bug.cgi?id=3571 Imported an attachment (id=262024)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED