Incorrect text appears when the user attempts to quit from direct edit mode with unsaved changes.
Submitted by cli..@..ba.org
Assigned to cli..@..ba.org
Link to original bug (#717515)
Description
---- Reported by clinton@yorba.org 2011-05-16 15:35:00 -0700 ----
Original Redmine bug id: 3613
Original URL: http://redmine.yorba.org/issues/3613
Searchable id: yorba-bug-3613
Original author: Clinton Rogers
Original description:
Steps to reproduce:
Open any valid image in Shotwell in direct-edit mode.
Modify the image, but do not save the changes.
Choose File>Quit <del>
or</del>
click on the [X] button in the title bar
and observe the results.
Notice that '(null)' appears as the dialog box's text.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Assignee changed from Anonymous to Clinton Rogers
Good catch. Please investigate!
Comment 2
Updated by Clinton Rogers over 2 years ago
The problem seems to lie in [negate_affirm_cancel_question](http://git.yorba.o rg/cgit.cgi/shotwell/tree/src/AppWindow.vala…)
Comment 3
Updated by Clinton Rogers over 2 years ago
Attaching a patch that:
Adds some self-defense against null string arguments to build_alert_body_text*().*
Forces markup to be on in negate_affirm_cancel_question() (due to what I believe might be a library-side bug, new_with_markup occasionally doesn't actually enable markup).
Comment 4
Updated by Clinton Rogers over 2 years ago
- Resolution set to fixed
- % Done changed from 0 to 100
Comment 5
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:52 UTC ---
This bug was previously known as bug 3613 at http://redmine.yorba.org/show_bug.cgi?id=3613 Imported an attachment (id=262014) Imported an attachment (id=262015)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED