Crop tool: the 'y' component comes before the 'x' one in the custom crop entry dialog.
Submitted by cli..@..ba.org
Link to original bug (#717510)
Description
---- Reported by clinton@yorba.org 2011-05-18 12:54:00 -0700 ----
Original Redmine bug id: 3618
Original URL: http://redmine.yorba.org/issues/3618
Searchable id: yorba-bug-3618
Original author: Clinton Rogers
Original description:
Steps to reproduce:
When viewing any photo, click on Crop.
Choose* Custom.*
Enter a sensible value in the first box and observe what happens to the displayed crop region.
Notice that the first entry field affects the height of the crop region's aspect ratio, while the second entry field affects the width. This is likely to confuse most users, who will expect 'x' or 'width' to come before 'y' or 'height'.
Originally reported via Launchpad.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
This is debatable. We normally talk about 3 × 5 or 4 × 6 postcards (not “5 × 3†or “6 × 4â€), and that's why our drop-down list of aspect ratios says “3 × 5†even when the associated crop rectangle has a landscape orientation. There are three possibilities here:
-
In the drop-down list, use Y x X (e.g. “3 × 5â€) and also use Y x X in custom dimensions. This is what we do today.
-
In the drop-down list, use Y x X (e.g. “3 × 5â€), but use X x Y in custom dimensions.
-
In the drop-down list, use X x Y (e.g. “5 × 3â€), and also use X x Y in custom dimensions.
No solution is perfect. With (1), custom dimensions are Y x X, which is the opposite of what some users might expect. With (2), the notation is inconsistent between the drop-down list and the entry boxes. With (3), we'd use non-standard names (“5 × 3â€) for standard aspect ratios (3 × 5).
I might very slightly lean toward (2).
Comment 2
Updated by Clinton Rogers over 2 years ago
I'd like to vote for (2) on the grounds that it'll more closely match what the user sees in an external editor (GIMP, RawTherapee and Bibble all use X before Y).
Comment 3
Updated by Lucas Beeler over 2 years ago
- Target version set to 0.11
We'll do (2) for Shotwell 0.11.
Comment 4
Updated by Clinton Rogers over 2 years ago
Patch submitted via email and attached; all it does is switch the width and height in the layout.
Comment 5
Updated by Clinton Rogers over 2 years ago
- Resolution set to fixed
- % Done changed from 0 to 100
Went with option #2 (closed); this way, named sizes from silver-halide photography stay intact, but custom aspect ratios are expressed in the same way screen coordinates are.
Comment 6
Updated by Adam Dingle over 2 years ago
- Target version changed from 0.11 to 0.10.1
Comment 7
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:52 UTC ---
This bug was previously known as bug 3618 at http://redmine.yorba.org/show_bug.cgi?id=3618 Imported an attachment (id=262010)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10.1
Resolution: RESOLVED FIXED