Enter key should close custom Crop, Red-eye, Adjust dialogs
Submitted by cli..@..ba.org
Assigned to Eric Gregory
Link to original bug (#717507)
Description
---- Reported by clinton@yorba.org 2011-05-18 18:39:00 -0700 ----
Original Redmine bug id: 3621
Original URL: http://redmine.yorba.org/issues/3621
Searchable id: yorba-bug-3621
Original author: Clinton Rogers
Original description:
To reproduce:
View any image in full-window mode.
Click on Crop.
Choose Custom.
Press [Tab] until OK no longer has focus.
Press [Enter] and observe the results.
Notice that [Enter] doesn't accept the settings and dismiss the custom crop dialog.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Subject changed from Crop tool: Pressing [Enter] in the custom settings dialog does not dismiss the dialog if the OK button doesn't have focus. to Enter key should close custom Crop, Red-eye, Adjust dialogs
We also need to think about whether the Enter key should close the Red-eye and Adjust dialogs. Strictly speaking, the GNOME interface dialogs discourage making the Close button the default (i.e. the button which Enter activates) in an instant apply window such as these:
http://developer.gnome.org/hig-book/3.0/windows-utility.html.en#default- buttons
On the other hand, I think it's useful to have a shortcut key which closes all these dialogs, and Enter seems like the logical choice. Furthermore,we've already decided that Enter will complete a crop action, and I think the editing dialog should behave consistently. So I actually vote that Enter should close all these dialogs.
Comment 2
Updated by Lucas Beeler over 2 years ago
- Target version set to 0.11
Comment 3
Updated by Lucas Beeler over 2 years ago
We should do something about this for 0.11. The behavior right now is a little counterintuitive.
Comment 4
Updated by Lucas Beeler over 2 years ago
- Assignee changed from Anonymous to Eric Gregory
Comment 5
Updated by Eric Gregory over 2 years ago
- Resolution set to fixed
- % Done changed from 0 to 100
Fixed in 4af327a5
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:52 UTC ---
This bug was previously known as bug 3621 at http://redmine.yorba.org/show_bug.cgi?id=3621
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.11
Resolution: RESOLVED FIXED