Photo size box should be disabled in Picasa options pane when only videos are selected
Submitted by Lucas Beeler
Assigned to cli..@..ba.org
Link to original bug (#717482)
Description
---- Reported by lucas@yorba.org 2011-02-17 14:42:00 -0800 ----
Original Redmine bug id: 3212
Original URL: http://redmine.yorba.org/issues/3212
Searchable id: yorba-bug-3212
Original author: Lucas Beeler
Original description:
Photo size box should be disabled in Picasa options pane when only videos are selected
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Clinton Rogers
Comment 2
Updated by Adam Dingle over 2 years ago
Rather than disabling the photo size box, it might be nicer not to display it at all (like we do for Flickr). Also, when only videos are selected, let's change the text “Photos will appear !in:†to read “Videos will appear in:†(again, like we do for Flickr).
Comment 3
Updated by Clinton Rogers over 2 years ago
Proposed patch submitted via email; it would do the following:
In the PicasaPublisher constructor, it finds out what media types the entries in host.get_publishables() have and saves that to a variable named media_types.
media_types is passed as an argument when we go to create the legacy options pane.
In the pane, if we see that the expression (media_types & PHOTO) is non-zero, we add the appropriate widgets, otherwise, we don't.
Comment 4
Updated by Clinton Rogers over 2 years ago
Revised version that includes the followup request as well.
Comment 5
Updated by Clinton Rogers over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
r2669
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3212 at http://redmine.yorba.org/show_bug.cgi?id=3212
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.9
Resolution: RESOLVED FIXED