change search bar background as user adjusts background color
Submitted by Adam Dingle
Assigned to Eric Gregory
Link to original bug (#717479)
Description
---- Reported by adam@yorba.org 2011-02-17 15:24:00 -0800 ----
Original Redmine bug id: 3215
Original URL: http://redmine.yorba.org/issues/3215
Searchable id: yorba-bug-3215
Original author: Adam Dingle
Original description:
If we decide to keep the dark search bar background, we'll need to resolve the following in order for everything to look nice:
- When the mouse moves over the toolbar buttons, their background currently turns white which contrasts harshly with the search bar background.
- While an import is in progress, the main window background is pure black, which constrasts unaesthetically with the dark grey search bar background.
- When the user modifies the Shotwell background, the search bar background currently doesn't change along with it, and the resulting contrast doesn't always look good.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle almost 3 years ago
Also, with the!ClearLookstheme the separators in the dark search bar look too bold. They look OK in Ambiance.
Comment 2
Updated by Adam Dingle almost 3 years ago
- Tracker changed from Bug to Feature
Comment 3
Updated by Adam Dingle almost 3 years ago
- Subject changed from visual changes to support dark search bar to change search bar background as user adjusts background color
The only change we still need to make here is to change the search bar background dynamically as the user adjusts the Shotwell background in the preferences dialog.
Comment 4
Updated by Jim Nelson over 2 years ago
- Status changed from Open to 5
- Resolution set to fixed
- % Done changed from 0 to 100
r2651
The second item in the description was taken care of with #3209.
There may be more color changes to come for the search bar. We can ticket those separately.
Comment 5
Updated by Adam Dingle over 2 years ago
- Status changed from 5 to 4
-
Resolution deleted (
<strike>
_fixed_</strike>
) - % Done changed from 100 to 0
When the user adjusts the background color we now dynamically update the search bar background, but we don't update the prelight and active colors of the search bar buttons, so those buttons look wrong in those states. Reopening.
Comment 6
Updated by Adam Dingle over 2 years ago
Also, we now have text labels in the search bar, but those labels still appear white even when I change the main background area to white. They should become dark when the background is white.
(Note that the text labels are hard-coded to the whitish color #ccc. We still want them to be this color, not full-on #ffffff, when the background is dark so that they aren't too attention-grabbing.)
Comment 7
Updated by Adam Dingle over 2 years ago
- Status changed from 4 to Review
- Assignee changed from Anonymous to Eric Gregory
Comment 8
Updated by Adam Dingle over 2 years ago
- Tracker changed from Feature to Bug
Comment 9
Updated by Eric Gregory over 2 years ago
I'm going to mention another aspect to this bug, which is that if the text box on the search bar has rounded corners and/or a margin, the background of it will not change color when the rest of the background changes.
Comment 10
Updated by Eric Gregory over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Fixed:
- Text color on background change
- Background around edges of text box on background change
r2708
Comment 11
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3215 at http://redmine.yorba.org/show_bug.cgi?id=3215
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.9
Resolution: RESOLVED FIXED