It's possible to inappropriately insert carriage returns in user input fields.
Submitted by cli..@..ba.org
Assigned to cli..@..ba.org
Link to original bug (#717450)
Description
---- Reported by clinton@yorba.org 2011-02-23 14:51:00 -0800 ----
Original Redmine bug id: 3245
Original URL: http://redmine.yorba.org/issues/3245
Searchable id: yorba-bug-3245
Original author: Clinton Rogers
Original description:
To reproduce:
In any area of the application where a media object, event or tag may be renamed, highlight one and secondary click.
Choose 'rename'.
In the name entry dialog, type “test (unicode character 0×000A) test†and accept this.
Notice that the renamed object will appear as:
test
test
Because allowing users to insert carriage returns or line feeds can have a
detrimental impact on window layout (to the point where it's possible to trick
GTK into trying to create a pixbuf taller than 65535 pixels), and aren't
needed in titles or tags, it might be helpful if the method
prepare_input_text()
replaced 0×000A and 0×000D with 0×0020 (space) when
called with the 'STRIP
' argument.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Clinton Rogers over 2 years ago
Proposed patch for this submitted via email
Comment 2
Updated by Adam Dingle over 2 years ago
- Target version set to 0.9
- Priority set to High
Comment 3
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Clinton Rogers
Comment 4
Updated by Clinton Rogers over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
r2691
Comment 5
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3245 at http://redmine.yorba.org/show_bug.cgi?id=3245
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.9
Resolution: RESOLVED FIXED