improve separation between search bar and photo area

Submitted by Adam Dingle

Description

---- Reported by adam@yorba.org 2011-03-01 14:58:00 -0800 ----

Original Redmine bug id: 3274
Original URL: http://redmine.yorba.org/issues/3274
Searchable id: yorba-bug-3274
Original author: Adam Dingle
Original description:

The line separating the search bar and the photo area is a bit too subtle. It would be nice to have a little more visual contrast here. Additionally, if I use the Preferences dialog to change the photo area background to solid black then the separator line vanishes completely. We should have a separator that looks good with every backgroud shade.

---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-16 14:41:00 -0700 ----

History

Comment 1

Updated by Adam Dingle over 2 years ago

Status changed from Open to Review
Assignee changed from Anonymous to Lucas Beeler

Comment 2

Updated by Adam Dingle over 2 years ago

Target version deleted (<strike>0.9</strike>)

Comment 3

Updated by Brad Woods over 1 year ago

File patch_bug_3274.diff added

I've added some padding to the bottom of the search toolbar. It makes it so that the search box doesn't touch the border between the toolbar and the picture window.

Comment 4

Updated by Lucas Beeler over 1 year ago

Status changed from Open to Review

Comment 5

Updated by Lucas Beeler over 1 year ago

I'll review this patch later today.

Comment 6

Updated by Lucas Beeler about 1 year ago

Status changed from Review to Open
Assignee deleted (<strike>Lucas Beeler</strike>)
Target version set to 0.14.0

@Brad: two issues with this patch. First, I think that 36 points is too tall -- at this size, the search bar takes up too much vertical screen space. Second, after applying your patch, the filter buttons are no longer square. Because they're fit to the height of their container, they appear as vertically elongated rectangles. You'll need to change the fit and/or packing settings on the buttons so that they retain their natural shape even as the search bar grows vertically before we can consider committing this patch.

Comment 7

Updated by Jim Nelson 11 months ago

Category set to ux

Comment 8

Updated by Jim Nelson 10 months ago

Target version changed from 0.14.0 to 0.15.0

Comment 9

Updated by Jim Nelson 6 months ago

Target version deleted (<strike>0.15.0</strike>)

--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---

This bug was previously known as bug 3274 at http://redmine.yorba.org/show_bug.cgi?id=3274 Imported an attachment (id=261985)

Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution

Resolution: RESOLVED FIXED