zoom icon is clipped on Ubuntu
Submitted by Adam Dingle
Assigned to cli..@..ba.org
Link to original bug (#717421)
Description
---- Reported by adam@yorba.org 2011-03-01 15:02:00 -0800 ----
Original Redmine bug id: 3275
Original URL: http://redmine.yorba.org/issues/3275
Searchable id: yorba-bug-3275
Original author: Adam Dingle
Original description:
On Ubuntu Natty, our zoom icon in the lower right-hand corner is clipped slightly by the resize handle in that corner. This happens both in the default Ambiance theme and in Clearlooks. We should nudge the icon slightly to avoid this artifact.
Related issues:
- related to shotwell - 4025: [gtk3] Remove spacers added due to Ubuntu's resize grip (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
The Close button in the Preferences dialog is clipped similarly.
Comment 2
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Adam Dingle
Comment 3
Updated by Adam Dingle over 2 years ago
We discussed. This seems like an Ubuntu bug, and we've decided not to work around this in the Shotwell code itself. In our PPA build, we may patch Shotwell to turn off the resize grip, time permitting.
Comment 4
Updated by Adam Dingle over 2 years ago
- Status changed from Review to 5
- Resolution set to wontfix
- % Done changed from 0 to 0
We've realized we're not building for Natty in our PPA, so we don't need to do this. Closing.
Comment 5
Updated by Adam Dingle over 2 years ago
-
Resolution deleted (
<strike>
_wontfix_</strike>
) - % Done changed from 0 to 0
- Target version changed from 0.9 to 0.11
- Subject changed from zoom icon is clipped on Natty to zoom icon is clipped on Ubuntu
Annoyingly, this still occurs on Oneiric alpha for anyone who builds from source. Ubuntu works around this in the official build, but I'd like to think we could find some better solution than that. Reopening.
Comment 6
Updated by Adam Dingle over 2 years ago
- Description updated (diff)
-
Assignee deleted (
<strike>
_Adam Dingle_</strike>
)
If we can't find a better solution, we'll need to work around this in our PPA build for Natty.
Comment 7
Updated by Lucas Beeler over 2 years ago
- Assignee set to Clinton Rogers
Comment 8
Updated by Clinton Rogers over 2 years ago
- Status changed from Open to Review
Patch submitted via email to move the zoom tool to the left.
In some themes, when the user is viewing a SinglePhotoPage and mouses over the 'next' button, the bottom-left corner is clipped by the resize handle as well; I didn't modify this. Please bounce this back to me if you want that changed as well.
Comment 9
Updated by Adam Dingle over 2 years ago
I'm not completely convinced that we want to move the zoom tool to the left here. I proposed that in the original description for this ticket, but we later decided (see comment 3) that we didn't want to change our user interface to work around an Ubuntu-specific problem, especially since it's possible to disable the Ubuntu-specific behavior by calling gtk_window_set_has_resize_grip(), as Ubuntu has done in their packaging for Shotwell 0.9 for Natty.
The right long-term solution here is to get Ubuntu to fix their resize handles (https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/704105). In the short term, we could simply patch our PPA build for Natty to call gtk_window_set_has_resize_grip(), just as Ubuntu has done.
But maybe you guys have already discussed this and decided that shifting the toolbar controls is the way to go. Lucas, since I'm on vacation you make the call here.
Comment 10
Updated by Adam Dingle over 2 years ago
Clinton wrote (via email):
p{=margin-left: 40px; }.
I saw Adam's note in the bug about calling gtk_window_set_has_resize_grip(), but it looks like that method may only exist in GTK+ 3, and not in 2.2x (source: http://developer.gnome.org/gtk/2.24/GtkWindow.html).
How shall we proceed?
In pure GNOME, gtk_window_set_has_resize_grip() exists only in GTK 3. Ubuntu has backported this to GTK 2, however - you can see this if you look at Ubuntu's packaging for GTK and for Shotwell. In Ubuntu's packaging for Shotwell 0.9 in Natty, they call this function to disable the resize grip. As I mentioned above, we may want to do the same in our PPA build for Shotwell 0.11.
Comment 11
Updated by Lucas Beeler over 2 years ago
Okay. I have Natty installed on my office workstation (Octomom) right now and have reached the following conclusion: we should commit Clinton's patch that moves the zoom slider left by 8 pixels. Feel free to chime in and disagree, but here's why I've made the call that I have:
- I'm not bothered at all by moving the zoom slider to the left. The visual effect is imperceptible for most people. Using my own eye for design, I think that, if anything, shifting the zoom slider left actually improves the appearance of the bottom toolbar.
- Modifying the PPA build only to call gtk_window_set_has_resize_grip() does nothing to eliminate the visual problem for users who build from source on Natty. This is the Linux/open source world and a lot of people just like building from source, so I think its important that these users aren't forced to see a clipped zoom icon.
Comment 12
Updated by Clinton Rogers over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
Comment 13
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3275 at http://redmine.yorba.org/show_bug.cgi?id=3275
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.11
Resolution: RESOLVED FIXED