Investigate Gtk.ActionGroup.set_translation_domain
Submitted by Jim Nelson
Link to original bug (#717393)
Description
---- Reported by jim@yorba.org 2011-03-08 11:50:00 -0800 ----
Original Redmine bug id: 3305
Original URL: http://redmine.yorba.org/issues/3305
Searchable id: yorba-bug-3305
Original author: Jim Nelson
Original description:
When we moved to gettext we had to restructure how we generated Gtk.!ActionEntry arrays because Vala didn't allow for calls to getttext's translation function in the statically-initialized arrays.
I recently discovered Gtk.!ActionGroup.set_translation_domain. It appears we can use untranslated strings in the ActionEntries and the ActionGroup object will translate them automatically with the specified domain.
This could potentially cut a lot of lines of code and make adding new actions much easier.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:46:00 -0700 ----
History
Comment 1
Updated by Jim Nelson over 2 years ago
One thing I just realized: We still have to mark the strings with the _() function for the gettext preprocessor to discover. That may be the rub to all of this.
Comment 2
Updated by Jim Nelson 11 months ago
- Target version set to 0.14.0
Comment 3
Updated by Jim Nelson 11 months ago
- Description updated (diff)
- Status changed from Open to 5
- Resolution set to wontfix
I looked into this for Geary and realized that the rub I mentioned in comment #1 (moved) is indeed the issue and that there's no real savings using this call.
Comment 4
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Invalid
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3305 at http://redmine.yorba.org/show_bug.cgi?id=3305
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.14.0
Resolution: RESOLVED INVALID