preferences dialog too tall for netbook screens
Submitted by Adam Dingle
Link to original bug (#717378)
Description
---- Reported by adam@yorba.org 2011-03-10 10:01:00 -0800 ----
Original Redmine bug id: 3320
Original URL: http://redmine.yorba.org/issues/3320
Searchable id: yorba-bug-3320
Original author: Adam Dingle
Original description:
The Shotwell preferences dialog won't fit vertically on netbook screens which are only 600 pixels tall:
https://bugs.launchpad.net/ubuntu/source/shotwell/bug/732710
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Valentín Barros over 2 years ago
This bug could be really annoying, but it could also be easy to fix.
I've created a patch (that I'm going to attach right now) that solves it by moving the “External Editors†area to a new tab. I choose that one because I think that the others are more related to Shotwell's internal behavior --but those are two options that aren't about Shotwell itself, but about other programs that Shotwell can use.
If you have any better idea in mind please explain and maybe I could help with it.
Comment 2
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Valentín Barros
Sanva,
thanks for the patch. Adding a new tab seems like a reasonable idea. Unfortunately shotwell.glade has changed a bit recently and so your patch won't apply to the current git master. Could you update your patch and resubmit?
Also, please note that we now prefer patches generated via 'git format-patch'. Thanks!
Comment 3
Updated by Adam Dingle over 2 years ago
- Target version set to 0.10
Comment 4
Updated by Valentín Barros over 2 years ago
OK, I've redone it with the last version of the repository.
I've done all my patches with git format-patch I tell you 'cause I don't know if it could be another problem with my patches even if created with format- patch.
Comment 5
Updated by Adam Dingle over 2 years ago
Oops, you're right – I now see that your previous patch was in fact formatted with 'git format-patch'. My mistake. Thanks for the updated patch. We'll review soon.
Comment 6
Updated by Adam Dingle over 2 years ago
I just tried the patch and visually it looks fine to me.
Comment 7
Updated by Lucas Beeler over 2 years ago
Ready to commit. Awaiting author's name.
Comment 8
Updated by Adam Dingle over 2 years ago
Once again, Sanva isValentn Barros (valentin@sanva.net).
Comment 9
Updated by Lucas Beeler over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Fixed in 7f7ec52a
Comment 10
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3320 at http://redmine.yorba.org/show_bug.cgi?id=3320 Imported an attachment (id=261971) Imported an attachment (id=261972)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED