Cannot untoggle disabled search bar button
Submitted by Eric Gregory
Link to original bug (#717375)
Description
---- Reported by eric@yorba.org 2011-03-10 18:48:00 -0800 ----
Original Redmine bug id: 3325
Original URL: http://redmine.yorba.org/issues/3325
Searchable id: yorba-bug-3325
Original author: Eric Gregory
Original description:
-
Flag at least one photo
-
Click the Flag button on the search filter toolbar
-
In the sidebar, select a tag that does not have any flagged photos associated with it
Result: as expected, you are not shown any photos. However, the Flag button on the search toolbar is disabled and cannot be untoggled!
The workaround for this is you have to go back to the Library page, untoggle the Flag button, then go back to the tag.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:45:00 -0700 ----
History
Comment 1
Updated by Eric Gregory over 2 years ago
A few thoughts on this after discussing with Jim.
- Should the buttons become untoggled if you go to a page where that button doesn't apply? I.e. if your tag doesn't have any flagged items, the button could untoggle and show all items. This seems to break the expectation that the search is static throughout all pages. It also potentially makes it harder to search for flagged items or items with a specific media type by clicking around on various pages in the sidebar.
- Should the a button in this case allow you to untoggle them manually? If so, does the button become disabled after you've untoggled it? On one hand, disabling the button seems a bit odd, but on the other hand it's consistent with the way we've designed the toolbar buttons.
- Should we disable the buttons at all? Perhaps we could indicate the “not applicable on this page†state with something other than disabled, like a different colored icon or an X over the icon.
Comment 2
Updated by Adam Dingle over 2 years ago
Hm. Thanks for pointing this case out – we hadn't thought about this before. I agree that the current behavior seems wrong. You've pointed out a number of possible workarounds. I think I probably lean toward leaving the button enabled in this situation so that the user can untoggle it, but having it become disabled as soon as it's untoggled. That might be slightly surprising to the user, but I think it would be consistent with the rest of the UI and would be a relatively rare event anyway.
We can discuss more on Monday.
Comment 3
Updated by Adam Dingle over 2 years ago
- Status changed from Open to 5
- Resolution set to invalid
- % Done changed from 0 to 0
We discussed. We've decided to solve this by no longer disabling the search bar buttons. I'll file a separate ticket for that.
Comment 4
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Invalid
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3325 at http://redmine.yorba.org/show_bug.cgi?id=3325
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.9
Resolution: RESOLVED INVALID