Add hierarchical tag support to the Import from F-Spot feature
Submitted by an unknown user
Link to original bug (#717372)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-03-12 03:19:00 -0800 ----
Original Redmine bug id: 3328
Original URL: http://redmine.yorba.org/issues/3328
Searchable id: yorba-bug-3328
Original author: Bruno Girin
Original description:
Once ticket #1401 is resolved, the Import from F-Spot feature will need to be updated to take advantage of hierarchical tags and properly import all tags from F-Spot.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Priority set to High
Comment 2
Updated by Adam Dingle over 2 years ago
- Target version set to 0.10
Comment 3
Updated by Adam Dingle over 2 years ago
-
Target version deleted (
<strike>
_0.10_</strike>
)
Comment 4
Updated by Adam Dingle over 2 years ago
- Target version set to 0.11
Comment 5
Updated by Bruno Girin over 2 years ago
- Assignee changed from Anonymous to Bruno Girin
Comment 6
Updated by Adam Dingle over 2 years ago
- Description updated (diff)
#3914 (closed) has been marked as a duplicate of this ticket.
Comment 7
Updated by Bruno Girin over 2 years ago
- File 0001-Hierarchical-tag-support-for-F-Spot-import.patch added
Patch attached to add hierarchical tag support to F-Spot import. It creates the correct hierarchy under "Import tags" but only imports top level tags directly under "Tags". Could that be an issue with the attach method in the Tag class?
Comment 8
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
Thanks so much, Bruno! Lucas, can you review?
Comment 9
Updated by Lucas Beeler over 2 years ago
No prob, Adam. I'll review when I next take a break from working on drag-and- drop!
Comment 10
Updated by Philippe Normand over 2 years ago
I've just tested this patch with ~5600 photos import, it took about 30 minutes but I guess it's because of my slow hard-drive :)
It worked well! One suggestion though, in the UI don't display "leaf" tags. They currently appear twice in the UI, once just under the "root" and below their respective parent tag.
Comment 11
Updated by Philippe Normand over 2 years ago
Multiple versions of the same picture are imported as different pictures in Shotwell, is that intended?
Comment 12
Updated by Bruno Girin over 2 years ago
Philippe, the import of multiple versions of the same photo as multiple photos is normal. At the moment, Shotwell only supports two versions of a photo: the original and a modified version, while F-Spot supports any number of versions. So to make it possible to import all versions of a given photograph, they are imported as different photos. Once Shotwell has the ability to have several versions of the same photos, the import will be updated to take advantage of that.
Comment 13
Updated by Lucas Beeler over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
Fixed in db96fa34. Thanks Bruno!
Comment 14
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3328 at http://redmine.yorba.org/show_bug.cgi?id=3328 Imported an attachment (id=261970)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.11
Resolution: RESOLVED FIXED