Shotwell reports directory name, not filename, after file fails to import
Submitted by Adam Dingle
Assigned to cli..@..ba.org
Link to original bug (#717330)
Description
---- Reported by adam@yorba.org 2011-03-17 15:30:00 -0700 ----
Original Redmine bug id: 3371
Original URL: http://redmine.yorba.org/issues/3371
Searchable id: yorba-bug-3371
Original author: Adam Dingle
Original description:
To see the problem:
Create an invalid image file. (An easy way to do this is to create an empty file named empty.jpg.)
Import the directory containing the invalid file into Shotwell.
You'll see an error like this:
1 unsupported photo skipped:
/home/adam/test
This is wrong. Shotwell should report the actual filename (e.g. /home/adam/test/empty.jpg).
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Eric Gregory over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Eric Gregory
Comment 2
Updated by Adam Dingle over 2 years ago
- Assignee changed from Eric Gregory to Clinton Rogers
Comment 3
Updated by Clinton Rogers over 2 years ago
Comment 4
Updated by Clinton Rogers over 2 years ago
Experimentation has revealed that when the BatchImportResult object that contains the path to the un-importable gets created, its constructor is getting passed the cut-off string, too.
Comment 5
Updated by Clinton Rogers over 2 years ago
…but the correct file path is known (as shown through get_path()).
Comment 6
Updated by Clinton Rogers over 2 years ago
Patch submitted via email.
Comment 7
Updated by Adam Dingle over 2 years ago
- Assignee changed from Clinton Rogers to Anonymous
- Target version changed from 0.9 to 0.10
May not be completely trivial to fix. Dropping from 0.9.
Comment 8
Updated by Adam Dingle over 2 years ago
- Assignee changed from Anonymous to Clinton Rogers
Comment 9
Updated by Clinton Rogers over 2 years ago
The path from the batch import job itself is incorrectly getting added to the batch import result somewhere along the way.
Comment 10
Updated by Clinton Rogers over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
r2815.
Comment 11
Updated by Adam Dingle over 2 years ago
- Target version changed from 0.10 to 0.9.1
Comment 12
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC ---
This bug was previously known as bug 3371 at http://redmine.yorba.org/show_bug.cgi?id=3371
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.9.1
Resolution: RESOLVED FIXED