library directory changes when removable media unavailable
Submitted by Adam Dingle
Assigned to Eric Gregory
Link to original bug (#717269)
Description
---- Reported by adam@yorba.org 2010-12-20 15:06:00 -0800 ----
Original Redmine bug id: 3000
Original URL: http://redmine.yorba.org/issues/3000
Searchable id: yorba-bug-3000
Original author: Adam Dingle
Original description:
To see the problem:
Start Shotwell with an empty library.
Plug in a USB flash drive. In the Preferences dialog, set the library directory to be the flash drive (e.g. listed as “4.1 GB Filesystem†on my machine).
Import a few photos, copying them into the library directory.
Exit Shotwell.
Eject the flash drive.
Restart Shotwell. The photos will be marked as missing.
Open the preferences dialog. You'll see that the library directory is now “mediaâ€, the parent directory of the flash drive mount point.
Exit Shotwell.
Reinsert the flash drive.
Start Shotwell, then open the preferences dialog again. The library directory is still “mediaâ€. This is bad because (a) Shotwell is unable to write to this directory, and (b) by auto-importing from this directory Shotwell may find files on other filesystems.
It appears that the library root is reset by step (7) above, opening the preferences dialog. If I skip step 7, then the library root remains correct in step 10.Would be nice to fix for 0.8 if still possible.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle almost 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Eric Gregory
Comment 2
Updated by Eric Gregory almost 3 years ago
This turns out to be a thorny issue. We want to allow the user to have an invalid folder set. FileChooserButton insists on selecting a valid folder, so if you pass it an invalid path, it will go to the parent folder until it finds a valid path.
FileChooserButton was added in #2698 (closed) and changeset r2304. Rolling it back out of the code is one option.
The simpler option is to let it continue to show the path it's selected, but only read from the FileChooserButton if the user clicks on it and sets a folder.
Comment 3
Updated by Eric Gregory almost 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
We decided to go with the second option listed above. If the library folder doesn't exist, the FileChooserButton will now show an incorrect path; however the button will not affect the path unless the user interacts with the button.
r2507
r2508
Comment 4
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:50 UTC ---
This bug was previously known as bug 3000 at http://redmine.yorba.org/show_bug.cgi?id=3000
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED