Add search filter toolbar
Submitted by Eric Gregory
Assigned to Jim Nelson
Link to original bug (#717175)
Description
---- Reported by eric@yorba.org 2011-01-13 19:08:00 -0800 ----
Original Redmine bug id: 3100
Original URL: http://redmine.yorba.org/issues/3100
Searchable id: yorba-bug-3100
Original author: Eric Gregory
Original description:
When discussing ticket #80 (closed), we decided that we wanted to add an entirely new search filter toolbar to Shotwell.
This toolbar will always be visible, and will have the following options:
- Text search
- Media type
- Ratings
- Flagged
The result of these will be ANDed together.
This toolbar will also show an option to view the contents of sub-tags for ticket #1401
As part of this bug, we will also merge the Videos and Photos pages into one sidebar item (“Media�) since it will be possible to see only photos or only videos by using the filter toolbar.
Additionally, we want to add a message in the current page that indicates when your filter setting has prevented anything from being shown. For example it could say “No media is visible in your current filter.â€
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Jim Nelson almost 3 years ago
I'd like to suggest one more media type to offer as a search option: RAW. This is common in other photo apps and I believe it makes sense for our users.
That opens up the possibility of filters for all photo file formats (PNG and TIFF when we do #601 (closed)). I don't feel strongly about those formats. RAW seems important enough to break out.
Comment 2
Updated by Eric Gregory almost 3 years ago
A few notes on the patch:
With Adam's help, I was able to change the background color of the toolbar. Not sure if we want to go in that direction or not. That starts on line 487 of SearchFilter.vala
Due to time constraints, I had to remove the code that grants focus to the text box on Ctrl-F. But if you want to add that back in, the code to grant focus to the search bar is in place. See set_search_box_focus() in LibraryWindow.
Also in LibraryWindow, look at line 1713 if you want to flip the toolbar to the bottom of the window. The way it works now is that the “notebook†contains the bottom toolbar, but there's a vbox that contains the search toolbar and the notebook. Placing it at the bottom would be… tricky. But doable.
If you want to break the search text into keywords, that could go into DefaultSearchViewFilter. Doing a simple AND of space-delimited keywords wouldn't add that much extra logic.
That's it! Enjoy working on this while I'm sipping mucha cerveza en Mexico.
Comment 3
Updated by Adam Dingle almost 3 years ago
- Status changed from Open to Review
- Assignee changed from Eric Gregory to Jim Nelson
Eric, thanks for all these changes. I hope the cerveza is tasty!
Note that with the patch Shotwell currently prints a warning “Find: missing action Find†on the console, and that numerous items are missing from the Edit menu (which is presumably related to the missing action). Jim, please clean up the patch to resolve these issues and commit.
Comment 4
Updated by Jim Nelson almost 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Committed!
r2634
Comment 5
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:49 UTC ---
This bug was previously known as bug 3100 at http://redmine.yorba.org/show_bug.cgi?id=3100 Imported an attachment (id=261913)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.9
Resolution: RESOLVED FIXED