[PATCH] Shotwell fails to build on trunk (r2580)
Submitted by an unknown user
Link to original bug (#717152)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-01-26 02:27:00 -0800 ----
Original Redmine bug id: 3127
Original URL: http://redmine.yorba.org/issues/3127
Searchable id: yorba-bug-3127
Original author: Siddhesh Poyarekar
Original description:
Shotwell fails to build from source in trunk currently due to a small error in src/plugins/mk/interfaces.mk. Attached one-liner patch fixes this.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle almost 3 years ago
- Status changed from Open to 5
- Resolution set to fixed
- % Done changed from 0 to 100
(I'm reviewing this patch since Jim, the Shotwell tech lead, is out sick today.)
make uses /bin/sh to execute its commands. On Ubuntu, /bin/sh is dash. On some systems it might be bash or other shells. I'm reluctant to use 'echo -e' since the -e argument is specific to bash. It does no harm with dash, but it's possible that other shells might issue an error when they see it.
There are various alternative solutions to this problem:
- Use two echo commands, one for each line we want to output.
- Use the printf command, which is more portable.
- Use cat with here-document syntax (e.g. 'cat << EOFFILE').
I think any of these would be fine. I've checked in a fix using printf.
Comment 2
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:49 UTC ---
This bug was previously known as bug 3127 at http://redmine.yorba.org/show_bug.cgi?id=3127 Imported an attachment (id=261907)
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED