allow user to flag photos
Submitted by Adam Dingle
Assigned to Jim Nelson
Link to original bug (#717089)
Description
---- Reported by adam@yorba.org 2010-11-02 15:45:00 -0700 ----
Original Redmine bug id: 2756
Original URL: http://redmine.yorba.org/issues/2756
Searchable id: yorba-bug-2756
Original author: Adam Dingle
Original description:
Several users have said they'd like some convenient way to build up a selection of photos in preparation for publishing them as a group or performing some other group operation on them. Tickets#2604and#2161are suggestions about how we might accomplish this.
We just discussed this at Yorba and have decided how we'd like to implement this. We'd like the user to be able to flag or unflag a photo. Flagged photos will have a small flag icon displayed over them in one of the upper corners. When one or more photos have been flagged, a sidebar item “Flagged†will appear. The user can select this sidebar item to see a view with photos which have been flagged. Once they've done that, they can easily publish all flagged photos as a set or perform any other operation on them.
There should be a keyboard shortcut which flags/unflags photos. This keyboard shortcut should also work in single-photo view, so that the user can easily flag/unflag there.
There should be some way the user can quickly unflag all photos: perhaps the user can right-click on the Flagged item in the sidebar and choose Clear.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Jules Kerssemakers about 3 years ago
Seconded, some suggestions (sorry if this is not the place for them, I'm newâ„¢, please redirect me to where you'd like me to post suggestions)
Some specific ideas for UI elements for this option:
- 2 items in the right-click menu: “flag photo(s)†and “unflag photo(s)â€
These should be greyed-out/enabled depending on the current selection (including single-photo-selections):
- if all selected photos are flagged: grey out flag-all, enable unflag-all
- if all selected photos are unflagged: enable flag-all, grey out unflag-all
- if some, but not all photos are flagged (mixed selection): enable flag-all, enable unflag-all
- 1 Item in the bottom toolbar (the one with rotate, enhance, publish etc)
Again, status of this icon should depend on current selection.
- if all selected photos are flagged: a discoloured/grey flag icon, tooltip “unflag selectionâ€
- if all selected photos are unflagged: a coloured flag icon, tooltip “flag selectionâ€
- if some, but not all photos are flagged (mixed selection): a mixed icon, half-coloured, half-greyed, tooltip “flag all (mixed selection)â€. (I.E.: same action as all-unflagged, but with a visually distinct icon/text to indicate to the user they are affecting a mix they may want to keep intact)
- The keyboard shortcut already mentioned
Comment 2
Updated by Adam Dingle about 3 years ago
@jkerssem: Yes, tickets are the best place to post suggestions/comments about Shotwell ideas.
Thanks for your suggestions. In the right click menu we're interested in saving space, so we could just have one menu item instead. If all selected photos are flagged, it would read “Unflag Photosâ€. If the selected photos are unflagged or a mix of flagged/unflagged, it would read “Flag Photosâ€, and would flag all photos when selected. This would require only one menu item and would be (almost) as useful. It would also mean that we could use a single keyboard shortcut for both commands, which would be convenient.
Your toolbar button suggestion sounds good. We're still undecided about whether we want to devote a toolbar button to this, though (space is precious down there).
Comment 3
Updated by Jules Kerssemakers about 3 years ago
You're welcome! Shotwell is progressing very rapidly into a 100% match for what I look for in a photo-manager, so thanks to you too!
@ 1-item-in-right-click-menu:
A very valid point, space is indeed valuable.
@toolbar button:
I think it's worth devoting a button to it. The idea of flagging seems to be you can rapidly select and flag a few photos here, another few there, and then have a simple way to reselect the entire group you just flagged. A sort of persistent version of what you normally do by shift+click/ctrl+click
You can then simply edit, tag, rotate, slideshow, export or whatever that selection (sorry for using “whatever†as a verb ;-))
Example use-case:
You just imported your 500 christmas-party pictures, and you are browsing them in single-photo-mode to see if they are in-focus, neatly framed, correctly rotated etc. While you're doing this you are also making a shortlist of photo's you'll export later to email to all your friends. These shortlisted photos would be flagged.
Without flagging, you'd have to loop through your collection twice, once to do the assorted corrections, and then another time from album-view to Ctrl+Click- select all photos to export.
In this scenario (and variants thereof), you'll want as few clicks/key-actions as possible to flag things, because you'll be flagging single photos a lot of times rather than making a big selection and flagging that all at once. This is why I'd suggest having a toolbar button, making flagging a one-click action (as opposed to a two-click action for the item in the right-click menu).
Following the same reasoning, I think the shortcut key should be a single, unmodified key. E.G. “f†instead of “Ctrl+fâ€
Another use-case for flagging is what Picasa does with “starringâ€, this seems to have a different meaning, more akin to “this picture is one of my favouritesâ€. However, this is already neatly captured by Shotwell's 0-5 star rating so I do not believe this should be mixed with flagging.
Comment 4
Updated by Adam Dingle about 3 years ago
@jkerssem: Thanks for your latest comments. The use case you describe is exactly why we want to add this flagging feature to Shotwell. I currently expect we'll implement this in the next few months.
We may remove the Slideshow button from the toolbar soon (see#2755). If we do that, we'll consider adding a Flag button in its place as you propose.
Comment 5
Updated by Jules Kerssemakers about 3 years ago
Well, “great minds think alike†they say :-)
I'm glad to see such active response to suggestions (both to mine and in general), that really gives me confidence that Shotwell is fast on its way to become the best photo-organizer. Keep up the good work!
BTW: in addition to the already mentioned “right-click Flagged items†> “clear all flagsâ€, maybe this same entry could also go in the main tags menu: “Clear flags from all photosâ€
Comment 6
Updated by Adam Dingle about 3 years ago
Thanks for the encouragement! :)
Regaring your last comment, do you mean the top-level Tags menu, or the Tags item in the sidebar? Assuming you mean the top-level menu, I think this command would more likely go in the Photos menu, where we have other commands that manipulate photo attributes such as title and rating.
Comment 7
Updated by Jules Kerssemakers about 3 years ago
I was referring to the top-level Tags menu. I suggested to put it there because the flagging option feels like a sort of quick-tag to me, rather than a photo-attribute. The argument that it is an attribute similar to rating is equally valid however, so “top-level†> “Photos†is also a good (if not better) location.
One thing of minor nit-picking concern could be that unlike other the actions currently in the Photo menu, this action would operate on ALL photo's rather than just the current selection. This may make it a bit of an odd one out, but I can't think of a better place to put it. (The exact same reasoning applies to “top-level†> “Tags†too)
As for the sidebar-tags item, I believe “flagged†should indeed deserve it's own item, probably sorted just above “Events†to prevent it from being pushed off-screen by lengthy collections. But if I read the original suggestion correctly, this was already your intention.
Comment 8
Updated by Cameron Braid about 3 years ago
I really like this idea.. Often when I am making a large selection of photos to export for someone else, often I will bump the wrong key or click somewhere accidentally. So what I tend to do is use a temporary tag.
Another idea that may be overkill for general use, bus useful for me, would be to have named flags, so that I could effectively have multiple selections that can be saved and restored without having to use tags. Another way of looking at it is to have 'non persistant' tags – tags that are not stored in the image files, but are just used via the interface to manage photos.
Comment 9
Updated by Jules Kerssemakers about 3 years ago
Ah of course, flag-actions should definitely not go in the top-level Tags menu; tags can/will/may/should be persisted into the exif-tag-information, flags shouldn't. So clearly, flags are different from tags and should not go into the tag menu.
As for Cameron's suggestion:
I think the idea is nice, but the use-cases are limited enough that it should not get a high priority. (sorry!)
As for implementation (because I was immediately inspired):
Maybe an advanced flagging feature (to be enabled in the preferences) where the user gets, in addition to the “simple flagâ€, access to “extra- flagsâ€.
The simple flag would work as described already, the extra-flags could be slightly less accesible, e.g. only by keyboard shortcut (Ctrl+F1..F12 springs to mind for me, giving 12 “extra-flagsâ€). In the sidebar these extra-flags could be nested under the Flags entry.
Comment 10
Updated by Jim Nelson about 3 years ago
To jump in, I'm thinking the flag state should persist, that way the user can return to their flagged photos even if they quit Shotwell.
What I mean is, Shotwell remembers flagged photos, but the flag is not stored in the photo itself as metadata.
Comment 11
Updated by kimaidou - about 3 years ago
I totally agree with Jim : the user should be able to see previously flaged pictures between shotwell sessions.
Comment 12
Updated by Cameron Braid about 3 years ago
Yep, I agree. What I meant by 'non persistant' is that they aren't stored in the files themselves, but they must be stored in the database
Comment 13
Updated by Jim Nelson about 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Jim Nelson
- Priority set to High
Comment 14
Updated by Jim Nelson about 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done set to 100
-
Priority deleted (
<strike>
_High_</strike>
)
r2345
Comment 15
Updated by Jim Nelson about 3 years ago
- Priority set to High
Comment 16
Updated by Anonymous over 2 years ago
Hey I see that this ticket has been closed some time back. What is the current status?
Has it been implemented? Is someone working on this feature?
Is it slated to be included in a certain future milestone?
Replying to adam:
Several users have said they'd like some convenient way to build up a selection of photos in preparation for publishing them as a group or performing some other group operation on them. Tickets#2604and#2161are suggestions about how we might accomplish this.
We just discussed this at Yorba and have decided how we'd like to implement this. We'd like the user to be able to flag or unflag a photo. Flagged photos will have a small flag icon displayed over them in one of the upper corners. When one or more photos have been flagged, a sidebar item “Flagged†will appear. The user can select this sidebar item to see a view with photos which have been flagged. Once they've done that, they can easily publish all flagged photos as a set or perform any other operation on them.
There should be a keyboard shortcut which flags/unflags photos. This keyboard shortcut should also work in single-photo view, so that the user can easily flag/unflag there.
There should be some way the user can quickly unflag all photos: perhaps the user can right-click on the Flagged item in the sidebar and choose Clear.
Comment 17
Updated by Adam Dingle over 2 years ago
Replying to [comment:18 chiraag]:
Hey I see that this ticket has been closed some time back. What is the current status?
Has it been implemented?
Yes: flagging photos was implemented last year and first appeared in Shotwell 0.8.
Comment 18
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:48 UTC ---
This bug was previously known as bug 2756 at http://redmine.yorba.org/show_bug.cgi?id=2756
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED